Skip to content

Commit ab60c0c

Browse files
authored
Merge pull request #224 from eed3si9n/wip/jdk17
Update readme
2 parents b9a9b78 + 0eeb9ac commit ab60c0c

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

README.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,18 @@ This plugin is quite prescriptive in that it forcibly manages the contents of th
3434

3535
### JDK settings
3636

37-
We recommend you set the following setting in `build.sbt`:
37+
sbt-github-actions currently defaults to using JDK 8 for testing and publishing. The following setting changes to using Temurin JDK 17 instead, which might be more common lately:
3838

3939
```scala
40-
// sbt-github-actions defaults to using JDK 8 for testing and publishing.
41-
// The following adds JDK 17 for testing.
42-
ThisBuild / githubWorkflowJavaVersions += JavaSpec.temurin("17")
40+
ThisBuild / githubWorkflowJavaVersions := List(JavaSpec.temurin("17"))
4341
```
4442

43+
The following setting changes to testing on Temurin JDK 17 and 25, and use JDK 17 for publishing:
44+
45+
```scala
46+
ThisBuild / githubWorkflowJavaVersions := List(JavaSpec.temurin("17"), JavaSpec.temurin("25"))
47+
ThisBuild / githubWorkflowPublishJavaVersion := JavaSpec.temurin("17")
48+
```
4549

4650
### Integration with sbt-ci-release
4751

0 commit comments

Comments
 (0)