backmerge 22-05-26 (next 16, alchemy key, hardhat v3)#427
Open
technophile-04 wants to merge 8 commits into
Open
backmerge 22-05-26 (next 16, alchemy key, hardhat v3)#427technophile-04 wants to merge 8 commits into
technophile-04 wants to merge 8 commits into
Conversation
# Conflicts: # packages/hardhat/hardhat.config.ts # packages/nextjs/next.config.ts # packages/nextjs/scaffold.config.ts # packages/nextjs/tsconfig.json # templates/base/packages/nextjs/app/blockexplorer/address/[address]/page.tsx.template.mjs # templates/base/packages/nextjs/package.json # yarn.lock
Users paste ABIs into externalContracts.ts and expect prettier to format on save / yarn format. The contracts/ exclusion was meant for generated deployedContracts.ts but caught externalContracts.ts too.
# Conflicts: # package.json # packages/hardhat/hardhat.config.ts # packages/hardhat/package.json # packages/hardhat/tsconfig.json # templates/base/packages/nextjs/app/blockexplorer/address/[address]/page.tsx.template.mjs # templates/solidity-frameworks/hardhat/packages/hardhat/scripts/runVerify.ts # yarn.lock
Member
|
one suggestion - let's move this line to
and then in deployment files just
instead of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Bundled backmerge of three upstream scaffold-eth-2 PRs:
Notes on the hardhat v3 migration (scaffold-eth#1272)
rocketh(replacing hardhat-deploy's runtime) — newpackages/hardhat/rocketh/{config,deploy,environment}.tsrelocated into the hardhat template.hardhat.config.tstemplate rewritten to v3defineConfigform:plugins, per-networktype(http/edr-simulated),solidity.profiles,generateTypedArtifacts, andtasks: [overrideTask("deploy")...]. ExportsetherscanApiKey(consumed by the newscripts/runVerify.ts)."type": "module"), uses@nomicfoundation/hardhat-toolbox-mocha-ethers,tsx,hardhat-deploy@^2,mocha, etc.node16module/moduleResolution,es2022target..output.jsonand contract path prefixedproject/contracts/. Foundry branch unchanged.enginesset to>=22.10.0(matching upstream) via the hardhat override; CIlint-instances.ymlnode bumped20.x → lts/*. The templated project workflow already useslts/*.Local validation (node 22.20.0)
Generated a hardhat project and ran the full flow — all green:
yarn compile✓yarn test✓ (2 passing)yarn deploy✓ (contract deployed,deployedContracts.tsgenerated)yarn verify --help✓ (etherscanApiKey import resolves)yarn hardhat:check-types/yarn hardhat:lint✓yarn next:check-types/yarn next:lint✓Foundry project generation verified (shared blockexplorer template unaffected).
Test plan