fix: correct bytecode prefix check for contract creation detection#1250
Open
Skywalkingzulu1 wants to merge 1 commit into
Open
fix: correct bytecode prefix check for contract creation detection#1250Skywalkingzulu1 wants to merge 1 commit into
Skywalkingzulu1 wants to merge 1 commit into
Conversation
Changed the contract creation bytecode prefix check from 0x60e06040 to 0x6080604 to match the standard Solidity init code. Standard Solidity init code starts with PUSH1 0x80 PUSH1 0x40 MSTORE (0x60806040), not 0x60e06040. This fixes the block explorer showing contract creation transactions as 'Unknown' instead of properly detecting them. Closes scaffold-eth#1246
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
Fixed the contract creation bytecode prefix check in
decodeTxData.ts.Before:
0x60e06040(incorrect)After:
0x6080604(matches standard Solidity init code)Standard Solidity init code starts with
PUSH1 0x80 PUSH1 0x40 MSTORE(0x60806040), not 0x60e06040.Impact
Contract creation transactions are now properly detected and won't appear as "Unknown" in the block explorer.
Testing
Closes #1246