UI tweaks/redesign#1282
Conversation
- --radius-field/box → 0 (light + dark) - .btn: drop shadow-md + rounded-full, add font-weight 600 - drop rounded-* / tinted-shadow utilities on cards, dropdowns, tables, avatar, faucet - thin borders for separation where shadows used to do the job Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- min-h-16 + border-b-2 border-base-300 (drop shadow) - self-stretch on navbar-start; raw <ul> instead of daisy menu menu-horizontal - nav links span full header height (h-full) with no rounding - mobile dropdown shadow-sm → shadow-lg Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Static page surfacing all DaisyUI variants (buttons, bg, text, borders, icons, form controls, badges, alerts, links) for theme work. Linked from header nav via SwatchIcon. Will be removed before merge. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- components/test/palettes.ts holds palette data (Default + Slate, light + dark) + apply/reset helpers - components/test/PaletteLoader.tsx mounts in root layout, replays stored palette on boot - /test page picker writes palette name to localStorage on Apply, removes on Reset - override applies via injected <style> with [data-theme="light"] and [data-theme="dark"] rules - minimal cards: name, swatches, Apply button Brief flash of default palette on hard refresh expected (loader runs post-hydration). Whole components/test/ folder + layout mount get deleted before merge. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Header active/hover/focus nav links: add text-secondary-content - debug/page.tsx banner: add text-secondary-content; drop now-conflicting text-neutral on inner p - DebugContracts contract picker hover: add hover:text-secondary-content - home page outline icons: drop fill-secondary (overrides outline icon's fill=none → solid blob) Surface-vs-button semantic ambiguity for secondary covered in PR description. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Light primary: #6f47ff → #6c24e0 (actual ethereum.org purple) - Light secondary: #525252 → #dde1e6 (soft pastel blue-grey, content flipped to dark) - Dark secondary: #4f4d4d → #3d4250 (blue-tinted dark grey) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Same #dde1e6 / #3d4250 secondary as Ethereum. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
rin-st
left a comment
There was a problem hiding this comment.
Love how it looks overall, predefined color schemes and how you show all the examples!
- Colors
I think we need to use latest daisyui version so it will be up to date with current docs. There's an update in #1280, but we can also make it here
But there is something about "semantics" that we could also fix here (this is something that has been bugging me for a long time). Some examples:
- ... the cleaner fix is to migrate surface usages to bg-base-300.
- Backwards... primary should be the user-facing CTA, not the dev-tool decoration.
- text-neutral used as muted-text. DaisyUI defines neutral as a non-saturated dark/light, not a "muted text" role.
Completely agree, let's fix all of these! Let's figure out our inconsistencies with the color docs https://daisyui.com/docs/colors/#list-of-all-daisyui-color-names and refactor colors to match it. For example, accent and info different from primary (or don't use them at all), maybe even use base-100 as default bg color to have better elevations. I didn't find many bugs, though, just one text-accent, and I'll add comments in the code for others
-
Themes
I like our current theme, we can leave it with maybe some minor changes. And I like Ethereum light theme, but dark bg is too dark, and dark base shades are mixed up, from darker to lighter base-200 -> base-100 -> base 300 -
Radius/shadows/height/other styles.
I like how it looks. But first thing I'm thinking of when I see this is what we need to change so it will look good everywhere. scaffold-ui -> se-2/create-eth -> SRE challenges custom non-scaffold-ui styles to match new ones (better with new images) -> other extensions custom styles if needed. Scaffold-ui bump with those changes should be major to not break the scaffold-ui styles of the apps where it's already used (if any). Assuming we're agree to change all of it
Removed all the radius and shadows.
There are still shadows in the code
And since we're continuing to work with daisy, let's close #1079?
|
Thanks Rinat. Pushed some tweaks.
Yeah, there are some inconsistencies in the current palette that we should fix! Maybe I good iteration would be to use the same current palette (+ removing border-radious and shadows + fixing inconsistencies). I guess it'll be easier to fix the surrounding stuff (s-ui, website, etc)
Updated here just in case too.
I left the ones for the dropdown and notifications (which I think make sense). Anything else? |
Agree!
Oh, I thought you wanted to remove all the shadows. Makes sense!
What do you think, should we fix those inconsistencies in this branch? I think in that case it will be a bit easier to update s-ui/sre - one time instead of 2 or more. But in the case of N iterations, it will be easier to track and fix bugs |
|
@carletex This looks great! I like sunset palette :-) Makes sense to be able to select the color palette at the scaffold.config file? So the devs can choose the colors easily... There are still some rounded boxes, like the notifications and the components on the debug page. I agree that the classes should be fixed, using better semantics for them, using primary for the real primary components. Thanks!! |

Opening this as a discussion-starter for a sharper, less-soft visual direction for SE-2.
In this first iteration, I included:
Once we agree on some of this basic stuff, we could ***merge and iterate later.
*** we need to adapt scaffold-ui too
But there is something about "semantics" that we could also fix here (this is something that has been bugging me for a long time). Some examples:
secondaryhas two jobs. Used both as a button color (btn-secondary, correct per DaisyUI) and as a muted surface background (bg-secondaryin Header active link,/debugbanner, contract-picker hover, theme toggle base... incorrect per DaisyUI, which intendsbase-200/base-300for muted surfaces). The current default palette gets away with it becausebg-secondaryis#dae8ff(light) and dark text remains readable. Any palette where secondary isn't a near-white surface immediately breaks readability. Patched the immediate bleed withtext-secondary-contentpairings; the cleaner fix is to migrate surface usages tobg-base-300.btn-primaryvsbtn-secondaryswapped. Header CTAs (Connect Wallet, Faucet) arebtn-secondary; Footer dev tools (price chip, Faucet modal trigger, Block Explorer link) arebtn-primary. Backwards... primary should be the user-facing CTA, not the dev-tool decoration.text-neutralused as muted-text. DaisyUI definesneutralas a non-saturated dark/light, not a "muted text" role.Would love to hear some first impressions!
PS. Be open-minded! We are so used to the SE-2 style that we need to be open-minded to accept a new style (it happened to me haha)