Skip to content

language tour: improve Traits page#3232

Draft
SethTisue wants to merge 1 commit into
scala:mainfrom
SethTisue:tour-traits
Draft

language tour: improve Traits page#3232
SethTisue wants to merge 1 commit into
scala:mainfrom
SethTisue:tour-traits

Conversation

@SethTisue

Copy link
Copy Markdown
Member

fixes #3097

@SethTisue SethTisue requested a review from bishabosha November 18, 2025 17:51
@SethTisue SethTisue marked this pull request as draft November 18, 2025 17:56
@SethTisue SethTisue removed the request for review from bishabosha November 18, 2025 17:56
@SethTisue SethTisue force-pushed the tour-traits branch 2 times, most recently from 547bba0 to fe643f8 Compare November 18, 2025 18:12
@SethTisue SethTisue marked this pull request as ready for review November 18, 2025 18:21
@SethTisue SethTisue marked this pull request as draft November 18, 2025 18:21
@SethTisue

SethTisue commented Nov 18, 2025

Copy link
Copy Markdown
Member Author

I'll have to figure out how to get the Scala-3-only example past mdoc — probably by making Scala 3 the default language version for mdoc.

@bishabosha

bishabosha commented Nov 23, 2025

Copy link
Copy Markdown
Member

I had an exploration of switching mdoc to scala 3 - basically a lot of localized pages either need updating or mdoc turned off. See here: main...bishabosha:docs.scala-lang:mdoc-use-scala3

My process was iterate running scripts/run-mdoc.sh, fix errors, and check for more errors, which could end up being a large time sink

@SethTisue

SethTisue commented Nov 24, 2025

Copy link
Copy Markdown
Member Author

@bishabosha I think we could reasonably just disable mdoc on the localized pages; many of them are quite out of date anyway

for any particular language, if a motivated volunteer wanted to do the work necessary to reenable mdoc for that language's pages, they could do so; we could open a "help wanted" issue on it

and/or could we have a magic comment or magic metadata on the top of certain pages to mark them as needing to be run with Scala 2 instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tour: traits page claims traits can't take parameters

2 participants