Disallow polymorphic function types over impure function types#26084
Merged
Conversation
Contributor
Author
|
@bracevac There are some scaladoc tests failing, which probably means scaladoc pages are now wrong as well. Can you take a look? |
bracevac
requested changes
May 19, 2026
Contributor
It's because the rendering test |
Contributor
Author
|
@bracevac Good suggestions. Can you take the PR over? |
Disallowed:
[A] => B => C
OK:
[A] => B -> C
Also OK (and equivalent to last one):
[A] -> B -> C
bracevac
approved these changes
May 27, 2026
noti0na1
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disallowed and rejected with an implementation restriction error:
OK:
Also OK (and equivalent to last one):
This is necessary since our current polymorphic function encoding requires that the type that's quantified over is a pure function type. We should fix that but until that's done we need to enforce the restriction.
Fixes #26035