Fix Documentation not building#1332
Merged
Merged
Conversation
daniel-wer
approved these changes
Jul 8, 2025
daniel-wer
left a comment
Member
There was a problem hiding this comment.
Thanks, LGTM. I'm not familiar with the docs build in the libs. Where can I see it failing and can we test whether it succeeds again now?
Member
Author
|
In the CI / GitHub actions, we can not test it. Docs builds run only on I tested it locally: That should be the docs and spawn a live server with the docs. You can then view the docs in your browser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
mkdocs-videoplugin is repsonsible for embedding YouTube videos and videos from S3/local in documents with an easy Markdown syntax.Unfortunately, the
mkdocs-videorepository is not makred as archieved. We had been using a fork that include a crictical fix for document parsing in modern Python versions (3.10+?). That fork was delete causing our docs builds to break.I forked the original
mkdocs-videorepo and apply said fixes. https://github.com/scalableminds/mkdocs-videoTodos:
Make sure to delete unnecessary points or to check all before merging: