Skip to content

Commit 9fcc3c9

Browse files
committed
docs: remove Key Design Decisions section from temporal endpoint proposal
1 parent 7142df6 commit 9fcc3c9

1 file changed

Lines changed: 0 additions & 22 deletions

File tree

docs/temporal-endpoint-type-proposal.md

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -95,28 +95,6 @@ The `model_bundle_id` points to a bundle whose command runs the Temporal activit
9595
| `infra/gateways/resources/templates/service_template_config_map_circleci.yaml` | Add `deployment-runnable-image-temporal-{cpu,gpu}.yaml` templates |
9696
| `charts/model-engine/templates/service_template_config_map.yaml` | Add same templates via Helm `range` loop for prod |
9797

98-
### Key Design Decisions (vs. original proposal)
99-
100-
**Annotations instead of a new HPA resource for autoscaling params:**
101-
- `temporal.scaleml.io/taskQueue`, `/minWorkers`, `/maxWorkers`, `/perWorker` are stored as Deployment annotations
102-
- `_get_temporal_autoscaling_params` reads these back in `get_resources` to populate `deployment_state`
103-
- This matches how `min_workers`/`max_workers` are read for KEDA-scaled endpoints
104-
105-
**`TEMPORAL_SERVER_HOSTNAME` from infra config, not request:**
106-
- Reads `hmi_config.temporal_server_hostname` (with empty-string fallback) so per-cluster config can override without touching the API
107-
- `TEMPORAL_SERVER_PORT` defaults to `7233` if not configured
108-
109-
**MVP: `replicas = max_workers` (fixed):**
110-
- No KEDA scaler created for temporal endpoints
111-
- `min_workers=0` is allowed (same as async) but has no effect in MVP — the deployment always has `max_workers` replicas
112-
113-
**No readiness probe:**
114-
- Temporal workers have no HTTP endpoint to probe
115-
- The template omits the readiness probe entirely; Kubernetes considers the pod ready as soon as the container starts
116-
117-
**No forwarder sidecar:**
118-
- The `main` container IS the Temporal worker
119-
- `sidecar.istio.io/inject: "false"` — no Istio sidecar either (workers don't serve HTTP traffic)
12098

12199
---
122100

0 commit comments

Comments
 (0)