Review feedback

Author: Diego Ardila

nucleus/constants.py

@@ -10,7 +10,7 @@
 ANNOTATION_TYPES = (BOX_TYPE, POLYGON_TYPE, SEGMENTATION_TYPE)
 ANNOTATION_UPDATE_KEY = "update"
 AUTOTAGS_KEY = "autotags"
-
+EXPORTED_ROWS = "exportedRows"
 CLASS_PDF_KEY = "class_pdf"
 CONFIDENCE_KEY = "confidence"
 DATASET_ID_KEY = "dataset_id"

nucleus/dataset.py

@@ -17,6 +17,7 @@
     DATASET_NAME_KEY,
     DATASET_SLICES_KEY,
     DEFAULT_ANNOTATION_UPDATE_MODE,
+    EXPORTED_ROWS,
     JOB_ID_KEY,
     NAME_KEY,
     REFERENCE_IDS_KEY,
@@ -347,4 +348,4 @@ def items_and_annotations(
             route=f"dataset/{self.id}/exportForTraining",
             requests_command=requests.get,
         )
-        return convert_export_payload(api_payload["exportedRows"])
+        return convert_export_payload(api_payload[EXPORTED_ROWS])

nucleus/slice.py

@@ -6,6 +6,7 @@
 from nucleus.dataset_item import DatasetItem
 from nucleus.job import AsyncJob
 from nucleus.utils import convert_export_payload, format_dataset_item_response
+from nucleus.constants import EXPORTED_ROWS
 
 
 class Slice:
@@ -115,7 +116,7 @@ def items_and_annotations(
             route=f"slice/{self.slice_id}/exportForTraining",
             requests_command=requests.get,
         )
-        return convert_export_payload(api_payload["exportedRows"])
+        return convert_export_payload(api_payload[EXPORTED_ROWS])
 
     def send_to_labeling(self, project_id: str):
         response = self._client.make_request(

tests/helpers.py

@@ -117,7 +117,7 @@ def reference_id_from_url(url):
     {
         **TEST_POLYGON_ANNOTATIONS[i],
         "confidence": 0.10 * i,
-        "class_pdf": None,
+        "class_pdf": TEST_POLYGON_MODEL_PDF,
     }
     if i != 0
     else {