fix(schedules): hide resolved ids for name aliases

Keep name-addressed schedule authorization failures on a name-based not-found response so denied requests do not reveal the resolved schedule id.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: jromualdez-scale

agentex/src/api/routes/agent_run_schedules.py

@@ -129,13 +129,16 @@ async def _resolve_name_alias_and_check(
     # and then authorize/operate on the immutable schedule id. Acting on the id,
     # not the name, keeps it the stable auth and mutation target even if the
     # label changes, and closes the rename/recreate race where a check on the old
-    # row could precede a write that lands on a new one. Absent names 404; denied
-    # resources collapse to 404.
+    # row could precede a write that lands on a new one. Both the absent-name and
+    # the denied-resource paths raise this same name-based 404 so an unauthorized
+    # caller can neither distinguish the two nor read back the resolved id.
+    not_found_message = f"Run schedule '{name}' for agent '{agent_id}' does not exist."
     schedule_id = await run_schedules_use_case.get_schedule_id_by_name(agent_id, name)
     await _check_schedule_or_collapse_to_404(
         authorization,
         build_run_schedule_authz_selector(agent_id, schedule_id),
         operation,
+        not_found_message=not_found_message,
     )
     return schedule_id
 

agentex/src/utils/schedule_authorization.py

@@ -12,11 +12,18 @@ async def _check_schedule_or_collapse_to_404(
     authorization: AuthorizationService,
     schedule_id: str,
     operation: AuthorizedOperationType,
+    not_found_message: str | None = None,
 ) -> None:
-    """Check an agent_schedule resource while hiding unreadable schedules."""
+    """Check an agent_schedule resource while hiding unreadable schedules.
+
+    ``not_found_message`` overrides the collapsed-404 body. Name-addressed routes
+    pass a name-based message so a denied resource is indistinguishable from an
+    absent one and the resolved id is never echoed back to an unauthorized caller.
+    """
     await check_resource_or_collapse_unreadable_to_404(
         authorization=authorization,
         resource=AgentexResource.schedule(schedule_id),
         operation=operation,
-        not_found_message=f"Item with id '{schedule_id}' does not exist.",
+        not_found_message=not_found_message
+        or f"Item with id '{schedule_id}' does not exist.",
     )

agentex/tests/unit/api/test_agent_run_schedules_authz.py

@@ -150,6 +150,29 @@ async def test_get_by_name_resolves_id_then_checks_read(self):
         assert called["operation"] == AuthorizedOperationType.read
         use_case.get_schedule.assert_awaited_once_with("agent-1", "schedule-1")
 
+    async def test_get_by_name_denied_404_hides_existence_and_resolved_id(self):
+        # A denied name-alias request must 404 with a name-based body identical to
+        # the absent-name case, and must never echo the resolved schedule id — else
+        # an unauthorized caller could probe existence / read back the id.
+        authorization = MagicMock()
+        authorization.check = AsyncMock(side_effect=AuthorizationError("denied"))
+        use_case = MagicMock()
+        use_case.get_schedule_id_by_name = AsyncMock(return_value="secret-id")
+        use_case.get_schedule = AsyncMock()
+
+        with pytest.raises(ItemDoesNotExist) as exc_info:
+            await get_run_schedule_by_name(
+                agent_id="agent-1",
+                name="nightly",
+                run_schedules_use_case=use_case,
+                authorization=authorization,
+            )
+
+        message = str(exc_info.value)
+        assert message == "Run schedule 'nightly' for agent 'agent-1' does not exist."
+        assert "secret-id" not in message
+        use_case.get_schedule.assert_not_called()
+
     async def test_get_denied_collapses_to_404_and_skips_use_case(self):
         authorization = MagicMock()
         authorization.check = AsyncMock(side_effect=AuthorizationError("denied"))