Skip to content

fix(observability): isolate SSE stream spans and continue ingress traceparent #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyntwang99 wants to merge 1 commit into
base: main
Choose a base branch
from
+456 −142
Open

fix(observability): isolate SSE stream spans and continue ingress traceparent #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions agentex/src/api/routes/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import json
from typing import Annotated, Any

from fastapi import APIRouter, HTTPException, Query
from fastapi import APIRouter, HTTPException, Query, Request
from fastapi.responses import StreamingResponse

from src.adapters.temporal.adapter_temporal import DTemporalAdapter
Expand Down Expand Up @@ -345,13 +345,18 @@ async def timeout_task(
async def stream_task_events(
task_id: DAuthorizedId(AgentexResourceType.task, AuthorizedOperationType.read),
stream_use_case: DStreamsUseCase,
request: Request,
) -> StreamingResponse:
"""
Streams task events using Server-Sent Events (SSE).
"""

return StreamingResponse(
stream_use_case.stream_task_events(task_id=task_id),
# Pass request headers so the stream span continues an inbound W3C
# traceparent (ingress edge) instead of starting an unrelated trace.
stream_use_case.stream_task_events(
task_id=task_id, carrier=dict(request.headers)
),
media_type="text/event-stream",
headers={
"Cache-Control": "no-cache",
Expand All @@ -369,13 +374,18 @@ async def stream_task_events(
async def stream_task_events_by_name(
task_name: DAuthorizedName(AgentexResourceType.task, AuthorizedOperationType.read),
stream_use_case: DStreamsUseCase,
request: Request,
) -> StreamingResponse:
"""
Streams task events using Server-Sent Events (SSE) by task name.
"""

return StreamingResponse(
stream_use_case.stream_task_events(task_name=task_name),
# Pass request headers so the stream span continues an inbound W3C
# traceparent (ingress edge) instead of starting an unrelated trace.
stream_use_case.stream_task_events(
task_name=task_name, carrier=dict(request.headers)
),
media_type="text/event-stream",
headers={
"Cache-Control": "no-cache",
Expand Down
Loading
Loading