Skip to content

Commit 5f63149

Browse files
test: teach the run-command config stubs about optimizer_harbor_args
Two tests in test_v05_harbor_http.py build the build-config as a SimpleNamespace carrying only the attributes run_command reads, so adding a field to HarborBuildConfig breaks them with an AttributeError that surfaces only as a non-zero exit code. Same convention as when agent_env was added: the stub grows with the config. The mirror of that also applied to this branch's own test, whose _Config predates agent_env and so broke once both fields were in the same code path. Suite now matches the base branch exactly: 11 pre-existing failures, none new. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent aa6a063 commit 5f63149

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

vero/tests/test_v05_harbor_http.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,11 @@ def test_harbor_run_uses_current_python_and_pinned_harbor_extra(tmp_path, monkey
260260

261261
config_path = tmp_path / "build.yaml"
262262
config_path.write_text("task_name: unused\n")
263-
config = SimpleNamespace(harbor_requirement="harbor[modal]==0.20.0", agent_env={})
263+
config = SimpleNamespace(
264+
harbor_requirement="harbor[modal]==0.20.0",
265+
agent_env={},
266+
optimizer_harbor_args=[],
267+
)
264268
observed = {}
265269

266270
def compile_task(_config, output):
@@ -313,7 +317,11 @@ def test_harbor_run_env_file_secrets_reach_subprocess_not_command_line(
313317
config_path.write_text("task_name: unused\n")
314318
env_file = tmp_path / "secrets.env"
315319
env_file.write_text("MODAL_TOKEN_ID=mt-id\nMODAL_TOKEN_SECRET=mt-secret\n")
316-
config = SimpleNamespace(harbor_requirement="harbor[modal]==0.20.0", agent_env={})
320+
config = SimpleNamespace(
321+
harbor_requirement="harbor[modal]==0.20.0",
322+
agent_env={},
323+
optimizer_harbor_args=[],
324+
)
317325
observed = {}
318326

319327
def compile_task(_config, output):

0 commit comments

Comments
 (0)