Skip to content

[SK-657] chore(deps): bump cffi >=1.15.1 → >=2.0.0#172

Open
dhawani wants to merge 1 commit into
mainfrom
chore/deps/SK-657-cffi-to-2.0.0
Open

[SK-657] chore(deps): bump cffi >=1.15.1 → >=2.0.0#172
dhawani wants to merge 1 commit into
mainfrom
chore/deps/SK-657-cffi-to-2.0.0

Conversation

@dhawani

@dhawani dhawani commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Linear: SK-657

Bumps cffi minimum bound from >=1.15.1 to >=2.0.0.

Package From To Risk
cffi >=1.15.1 >=2.0.0 Medium (major version)

Why this is safe

  • cryptography>=46.0.6 (already required by this SDK) hard-requires cffi 2.0+, meaning all current SDK consumers already have cffi 2.0.0 installed — this change makes the explicit constraint consistent with reality
  • The SDK does not call any cffi API directly; cffi is only used transitively via cryptography
  • cffi 2.0.0 only drops Python 2 support — this SDK requires Python 3

Test plan

  • make lint passes (static compile check)
  • make setup installs cleanly with cffi 2.0.0
  • No cffi API calls in SDK source — zero code changes needed
  • Integration tests require live SCALEKIT_ENV_URL credentials (pre-existing, unaffected)

Generated by Claude Code

cffi 2.0.0 is the current stable release. cryptography>=46.0.6 already
requires cffi 2.0+, so all SDK consumers have it installed. Bumping the
explicit lower bound makes the constraint consistent with reality.

https://linear.app/scalekit/issue/SK-657
@dhawani dhawani requested a review from Avinash-Kamath as a code owner June 12, 2026 08:32
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@dhawani, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 2 hours, 39 minutes, and 3 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8c061453-0042-45ae-93b7-418f2e62bd94

📥 Commits

Reviewing files that changed from the base of the PR and between 6945518 and f4930fd.

📒 Files selected for processing (1)
  • setup.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/deps/SK-657-cffi-to-2.0.0

Comment @coderabbitai help to get the list of available commands and usage tips.

dhawani commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

CI failure is pre-existing and unrelated to this PR.

The 3 failing tests are all in test_providers.py with TypeError: 'NoneType' object is not iterable in custom_provider.py:263 — caused by the live API returning fields: null in an AuthPattern, which the code doesn't guard against.

Evidence this predates our change: the last Build run on main itself (run 27404354042, commit 6945518) failed with errors=4 — the same test, one more error than our PR.

This PR only modifies setup.py to bump cffi minimum from >=1.15.1 to >=2.0.0. Since cryptography>=46.0.6 already hard-requires cffi 2.0+, this constraint change has zero behavioral impact on any code path.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants