remove utility command group + doc review

Author: Mia-Cross

cmd/scw/testdata/test-all-usage-k8s-pool-add-external-node-usage.golden

@@ -1,6 +1,6 @@
 🎲🎲🎲 EXIT CODE: 0 🎲🎲🎲
 🟥🟥🟥 STDERR️️ 🟥🟥🟥️
-Add an external node to a Kosmos pool. 
+Add an external node to a Kosmos Pool. 
 This will connect via SSH to the node, download the multicloud configuration script and run it with sudo privileges.
 Keep in mind that your external node needs to have wget in order to download the script.
 
@@ -9,7 +9,7 @@ USAGE:
 
 ARGS:
   node-ip           IP address of the external node
-  pool-id           ID of the pool the node should be added to
+  pool-id           ID of the Pool the node should be added to
   [username=root]   Username used for the SSH connection
   [region=fr-par]   Region to target. If none is passed will use default region from the config
 

cmd/scw/testdata/test-all-usage-k8s-pool-usage.golden

@@ -7,16 +7,14 @@ USAGE:
   scw k8s pool <command>
 
 AVAILABLE COMMANDS:
+  add-external-node Add an external node to a Kosmos Pool
   create            Create a new Pool in a Cluster
   delete            Delete a Pool in a Cluster
   get               Get a Pool in a Cluster
   list              List Pools in a Cluster
   update            Update a Pool in a Cluster
   upgrade           Upgrade a Pool in a Cluster
 
-UTILITY COMMANDS:
-  add-external-node Add an external node to a Kosmos pool
-
 WORKFLOW COMMANDS:
   wait              Wait for a pool to reach a stable state
 

docs/commands/k8s.md

@@ -34,7 +34,7 @@ This API allows you to manage Kubernetes Kapsule and Kosmos clusters.
   - [Replace a Node in a Cluster](#replace-a-node-in-a-cluster)
   - [Wait for a node to reach a stable state](#wait-for-a-node-to-reach-a-stable-state)
 - [Kapsule pool management commands](#kapsule-pool-management-commands)
-  - [Add an external node to a Kosmos pool](#add-an-external-node-to-a-kosmos-pool)
+  - [Add an external node to a Kosmos Pool](#add-an-external-node-to-a-kosmos-pool)
   - [Create a new Pool in a Cluster](#create-a-new-pool-in-a-cluster)
   - [Delete a Pool in a Cluster](#delete-a-pool-in-a-cluster)
   - [Get a Pool in a Cluster](#get-a-pool-in-a-cluster)
@@ -962,9 +962,9 @@ A pool is a set of identical nodes
 A pool has a name, a size (its desired number of nodes), node number limits (min, max), and a Scaleway Instance type. Changing those limits increases/decreases the size of a pool. As a result and depending on its load, the pool will grow or shrink within those limits when autoscaling is enabled.
 
 
-### Add an external node to a Kosmos pool
+### Add an external node to a Kosmos Pool
 
-Add an external node to a Kosmos pool. 
+Add an external node to a Kosmos Pool. 
 This will connect via SSH to the node, download the multicloud configuration script and run it with sudo privileges.
 Keep in mind that your external node needs to have wget in order to download the script.
 
@@ -980,7 +980,7 @@ scw k8s pool add-external-node [arg=value ...]
 | Name |   | Description |
 |------|---|-------------|
 | node-ip | Required | IP address of the external node |
-| pool-id | Required | ID of the pool the node should be added to |
+| pool-id | Required | ID of the Pool the node should be added to |
 | username | Default: `root` | Username used for the SSH connection |
 | region | Default: `fr-par` | Region to target. If none is passed will use default region from the config |
 

internal/namespaces/k8s/v1/custom_pool.go

@@ -150,14 +150,13 @@ type k8sPoolAddExternalNodeRequest struct {
 
 func k8sPoolAddExternalNodeCommand() *core.Command {
 	return &core.Command{
-		Short: `Add an external node to a Kosmos pool`,
-		Long: `Add an external node to a Kosmos pool. 
+		Short: `Add an external node to a Kosmos Pool`,
+		Long: `Add an external node to a Kosmos Pool. 
 This will connect via SSH to the node, download the multicloud configuration script and run it with sudo privileges.
 Keep in mind that your external node needs to have wget in order to download the script.`,
 		Namespace: "k8s",
 		Resource:  "pool",
 		Verb:      "add-external-node",
-		Groups:    []string{"utility"},
 		ArgsType:  reflect.TypeOf(k8sPoolAddExternalNodeRequest{}),
 		ArgSpecs: core.ArgSpecs{
 			{
@@ -167,7 +166,7 @@ Keep in mind that your external node needs to have wget in order to download the
 			},
 			{
 				Name:     "pool-id",
-				Short:    `ID of the pool the node should be added to`,
+				Short:    `ID of the Pool the node should be added to`,
 				Required: true,
 			},
 			{
@@ -209,7 +208,7 @@ Keep in mind that your external node needs to have wget in order to download the
 			client := core.ExtractClient(ctx)
 			secretKey, _ := client.GetSecretKey()
 			execScriptArgs := []string{
-				"",
+				"", // Adding a space to prevent the command from being logged in history as it shows the secret key
 				"SCW_SECRET_KEY=" + secretKey,
 				"./init_kosmos_node.sh",
 			}