Skip to content

Commit ea43837

Browse files
scaleway-botPrototool Botestellesoulard
authored
feat(interlink): support hosted L2 partners & links (#5598)
Co-authored-by: Prototool Bot <prototool-bot@scaleway.com> Co-authored-by: Estelle Soulard <esoulard@scaleway.com>
1 parent 88e1f5e commit ea43837

5 files changed

Lines changed: 31 additions & 11 deletions

File tree

cmd/scw/testdata/test-all-usage-interlink-link-list-usage.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ ARGS:
1919
[vpc-id] Filter for links attached to this VPC
2020
[routing-policy-id] Filter for links using this routing policy
2121
[pairing-key] Filter for the link with this pairing_key
22-
[kind] Filter for hosted or self-hosted links (hosted | self_hosted)
22+
[kind] Filter for hosted or self-hosted links (hosted | self_hosted | l2_hosted | l3_hosted)
2323
[connection-id] Filter for links self-hosted on this connection
2424
[organization-id] Organization ID to filter for
2525
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | it-mil | nl-ams | pl-waw | all)

cmd/scw/testdata/test-all-usage-interlink-partner-list-usage.golden

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ USAGE:
88
ARGS:
99
[order-by] Order in which to return results (name_asc | name_desc)
1010
[pop-ids.{index}] Filter for partners present (offering a connection) in one of these PoPs
11+
[l3-connectivity] Filter for partners supporting L3 connectivity
1112
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | it-mil | nl-ams | pl-waw | all)
1213

1314
FLAGS:

cmd/scw/testdata/test-all-usage-interlink-pop-list-usage.golden

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,14 @@ USAGE:
66
scw interlink pop list [arg=value ...]
77

88
ARGS:
9-
[order-by] Order in which to return results (name_asc | name_desc)
10-
[name] PoP name to filter for
11-
[hosting-provider-name] Hosting provider name to filter for
12-
[partner-id] Filter for PoPs hosting an available shared connection from this partner
13-
[link-bandwidth-mbps] Filter for PoPs with a shared connection allowing this bandwidth size. Note that we cannot guarantee that PoPs returned will have available capacity.
14-
[dedicated-available] Filter for PoPs with a dedicated connection available for self-hosted links.
15-
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | it-mil | nl-ams | pl-waw | all)
9+
[order-by] Order in which to return results (name_asc | name_desc)
10+
[name] PoP name to filter for
11+
[hosting-provider-name] Hosting provider name to filter for
12+
[partner-id] Filter for PoPs hosting an available shared connection from this partner
13+
[link-bandwidth-mbps] Filter for PoPs with a connection allowing this bandwidth size. Note that we cannot guarantee that PoPs returned will have available capacity.
14+
[dedicated-available] Filter for PoPs with a dedicated connection available for self-hosted links.
15+
[l3-connectivity-partners] Filter for PoPs with a shared connection available from a partner supporting L3 connectivity
16+
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | it-mil | nl-ams | pl-waw | all)
1617

1718
FLAGS:
1819
-h, --help help for list

docs/commands/interlink.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ scw interlink link list [arg=value ...]
269269
| vpc-id | | Filter for links attached to this VPC |
270270
| routing-policy-id | | Filter for links using this routing policy |
271271
| pairing-key | | Filter for the link with this pairing_key |
272-
| kind | One of: `hosted`, `self_hosted` | Filter for hosted or self-hosted links |
272+
| kind | One of: `hosted`, `self_hosted`, `l2_hosted`, `l3_hosted` | Filter for hosted or self-hosted links |
273273
| connection-id | | Filter for links self-hosted on this connection |
274274
| organization-id | | Organization ID to filter for |
275275
| region | Default: `fr-par`<br />One of: `fr-par`, `it-mil`, `nl-ams`, `pl-waw`, `all` | Region to target. If none is passed will use default region from the config |
@@ -341,6 +341,7 @@ scw interlink partner list [arg=value ...]
341341
|------|---|-------------|
342342
| order-by | One of: `name_asc`, `name_desc` | Order in which to return results |
343343
| pop-ids.{index} | | Filter for partners present (offering a connection) in one of these PoPs |
344+
| l3-connectivity | | Filter for partners supporting L3 connectivity |
344345
| region | Default: `fr-par`<br />One of: `fr-par`, `it-mil`, `nl-ams`, `pl-waw`, `all` | Region to target. If none is passed will use default region from the config |
345346

346347

@@ -389,8 +390,9 @@ scw interlink pop list [arg=value ...]
389390
| name | | PoP name to filter for |
390391
| hosting-provider-name | | Hosting provider name to filter for |
391392
| partner-id | | Filter for PoPs hosting an available shared connection from this partner |
392-
| link-bandwidth-mbps | | Filter for PoPs with a shared connection allowing this bandwidth size. Note that we cannot guarantee that PoPs returned will have available capacity. |
393+
| link-bandwidth-mbps | | Filter for PoPs with a connection allowing this bandwidth size. Note that we cannot guarantee that PoPs returned will have available capacity. |
393394
| dedicated-available | | Filter for PoPs with a dedicated connection available for self-hosted links. |
395+
| l3-connectivity-partners | | Filter for PoPs with a shared connection available from a partner supporting L3 connectivity |
394396
| region | Default: `fr-par`<br />One of: `fr-par`, `it-mil`, `nl-ams`, `pl-waw`, `all` | Region to target. If none is passed will use default region from the config |
395397

396398

internal/namespaces/interlink/v1beta1/interlink_cli.go

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,13 @@ func interlinkPartnerList() *core.Command {
129129
Deprecated: false,
130130
Positional: false,
131131
},
132+
{
133+
Name: "l3-connectivity",
134+
Short: `Filter for partners supporting L3 connectivity`,
135+
Required: false,
136+
Deprecated: false,
137+
Positional: false,
138+
},
132139
core.RegionArgSpec(
133140
scw.RegionFrPar,
134141
scw.RegionItMil,
@@ -236,7 +243,7 @@ func interlinkPopList() *core.Command {
236243
},
237244
{
238245
Name: "link-bandwidth-mbps",
239-
Short: `Filter for PoPs with a shared connection allowing this bandwidth size. Note that we cannot guarantee that PoPs returned will have available capacity.`,
246+
Short: `Filter for PoPs with a connection allowing this bandwidth size. Note that we cannot guarantee that PoPs returned will have available capacity.`,
240247
Required: false,
241248
Deprecated: false,
242249
Positional: false,
@@ -248,6 +255,13 @@ func interlinkPopList() *core.Command {
248255
Deprecated: false,
249256
Positional: false,
250257
},
258+
{
259+
Name: "l3-connectivity-partners",
260+
Short: `Filter for PoPs with a shared connection available from a partner supporting L3 connectivity`,
261+
Required: false,
262+
Deprecated: false,
263+
Positional: false,
264+
},
251265
core.RegionArgSpec(
252266
scw.RegionFrPar,
253267
scw.RegionItMil,
@@ -457,6 +471,8 @@ func interlinkLinkList() *core.Command {
457471
EnumValues: []string{
458472
"hosted",
459473
"self_hosted",
474+
"l2_hosted",
475+
"l3_hosted",
460476
},
461477
},
462478
{

0 commit comments

Comments
 (0)