Skip to content

feat(vcr): normalize buildpacks-related data for container deploy tests#3069

Merged
remyleone merged 1 commit into
scaleway:mainfrom
Mia-Cross:vcr_normalize_buildpacks_data
May 22, 2026
Merged

feat(vcr): normalize buildpacks-related data for container deploy tests#3069
remyleone merged 1 commit into
scaleway:mainfrom
Mia-Cross:vcr_normalize_buildpacks_data

Conversation

@Mia-Cross
Copy link
Copy Markdown
Contributor

In the CLI test Test_Deploy/Buildpack from the container package, we need to normalize buildpacks IDs in the URLs of both the request and the cassette for them to match.

Needed for scaleway-cli#5580

@Mia-Cross Mia-Cross self-assigned this May 22, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.38%. Comparing base (2e9e4ce) to head (320b057).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
vcr/vcr.go 0.00% 8 Missing ⚠️
vcr/matchers.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3069      +/-   ##
========================================
- Coverage   3.38%   3.38%   -0.01%     
========================================
  Files        164     164              
  Lines      54333   54346      +13     
========================================
  Hits        1839    1839              
- Misses     52208   52221      +13     
  Partials     286     286              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mia-Cross Mia-Cross marked this pull request as ready for review May 22, 2026 13:36
@Mia-Cross Mia-Cross requested a review from remyleone as a code owner May 22, 2026 13:36
@remyleone remyleone added this pull request to the merge queue May 22, 2026
Merged via the queue into scaleway:main with commit b75cc1c May 22, 2026
10 checks passed
@Mia-Cross Mia-Cross deleted the vcr_normalize_buildpacks_data branch May 22, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants