Skip to content

feat(Link): update the decoration and sentiment behavior, fix styles for the different sizes#6435

Draft
jsulpis wants to merge 1 commit into
mainfrom
feat/link-styles
Draft

feat(Link): update the decoration and sentiment behavior, fix styles for the different sizes#6435
jsulpis wants to merge 1 commit into
mainfrom
feat/link-styles

Conversation

@jsulpis
Copy link
Copy Markdown
Member

@jsulpis jsulpis commented May 13, 2026

Summary

Type

  • Enhancement

Summarize concisely:

[FROZEN] waiting for the design to make the links visible for the prominence: "high" variant
image

What is expected?

  • links to internal page have sentiment primary which has no underline
  • links to external page have sentiment info which has a dotted underline and can have a visited state

The following changes were made:

  • update styles
  • mark the "variant" property as deprecated (it has no effect)
  • update the stories

Relevant logs and/or screenshots

Page Before After
url screenshot screenshot
url screenshot screenshot

@jsulpis jsulpis requested a review from lisalupi as a code owner May 13, 2026 12:21
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 13, 2026

🦋 Changeset detected

Latest commit: cd219bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.29%. Comparing base (f95aba8) to head (e61be72).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6435      +/-   ##
==========================================
- Coverage   92.36%   92.29%   -0.08%     
==========================================
  Files         526      526              
  Lines        9278     9277       -1     
  Branches     3447     3422      -25     
==========================================
- Hits         8570     8562       -8     
- Misses        708      715       +7     
Files with missing lines Coverage Δ
packages/ui/src/components/Banner/index.tsx 95.12% <100.00%> (ø)
packages/ui/src/components/Link/constants.ts 100.00% <100.00%> (ø)
packages/ui/src/components/Link/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Link/styles.css.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f95aba8...e61be72. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsulpis jsulpis force-pushed the feat/link-styles branch from e61be72 to cd219bd Compare May 13, 2026 12:50
@jsulpis jsulpis requested review from mhervouet and removed request for mhervouet May 18, 2026 07:48
@jsulpis jsulpis marked this pull request as draft May 18, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants