feat(Logo): dark logos#6481
Open
lisalupi wants to merge 3 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 53bc2d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6481 +/- ##
==========================================
+ Coverage 92.29% 92.34% +0.05%
==========================================
Files 525 529 +4
Lines 9255 9383 +128
Branches 3450 3486 +36
==========================================
+ Hits 8542 8665 +123
- Misses 713 718 +5 see 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jsulpis
reviewed
May 26, 2026
Member
jsulpis
left a comment
There was a problem hiding this comment.
- Datadog logo is not very readable in dark, and there is a white version in their press kit
- OpenAI logo is invisible in dark, there is a white version in their brand page
- Owncloud logo is invisible in dark, there is a white version in their brand page (maybe also update the light version with "A Kiteworks Company" ?)
jsulpis
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarize concisely:
Logosnow support dark versions. When no dark version is provided (i.e./assets/dark/NAME.svgdoes not exist while/assets/light/NAME.svgdoes), the light version is displayed as a fallback. Light assets are required, as components are indexed from/assets/light/.