Skip to content

feat(Logo): dark logos#6481

Open
lisalupi wants to merge 3 commits into
mainfrom
feat/dark-logos
Open

feat(Logo): dark logos#6481
lisalupi wants to merge 3 commits into
mainfrom
feat/dark-logos

Conversation

@lisalupi
Copy link
Copy Markdown
Collaborator

Summary

Type

  • Feature

Summarize concisely:

Logos now support dark versions. When no dark version is provided (i.e. /assets/dark/NAME.svg does not exist while /assets/light/NAME.svg does), the light version is displayed as a fallback. Light assets are required, as components are indexed from /assets/light/.

@lisalupi lisalupi requested review from a team and mhervouet May 26, 2026 13:27
@lisalupi lisalupi self-assigned this May 26, 2026
@lisalupi lisalupi requested review from a team and jsulpis as code owners May 26, 2026 13:27
@lisalupi lisalupi requested review from vincentaudebert and removed request for a team May 26, 2026 13:27
@lisalupi lisalupi added the enhancement New feature or request label May 26, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 26, 2026

🦋 Changeset detected

Latest commit: 53bc2d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ultraviolet/icons Minor
@ultraviolet/form Patch
@ultraviolet/ui Patch
@ultraviolet/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.34%. Comparing base (cae1be7) to head (53bc2d8).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6481      +/-   ##
==========================================
+ Coverage   92.29%   92.34%   +0.05%     
==========================================
  Files         525      529       +4     
  Lines        9255     9383     +128     
  Branches     3450     3486      +36     
==========================================
+ Hits         8542     8665     +123     
- Misses        713      718       +5     

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cae1be7...53bc2d8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@jsulpis jsulpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Datadog logo is not very readable in dark, and there is a white version in their press kit
  • OpenAI logo is invisible in dark, there is a white version in their brand page
  • Owncloud logo is invisible in dark, there is a white version in their brand page (maybe also update the light version with "A Kiteworks Company" ?)
image image image

Comment thread utils/scripts/generate-icons-file.tsx
Comment thread utils/scripts/generate-icons-file.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants