Skip to content

fix(OfferList): disable expand on a row#6488

Open
lisalupi wants to merge 1 commit into
mainfrom
fix/offer-list-disabled-expandable
Open

fix(OfferList): disable expand on a row#6488
lisalupi wants to merge 1 commit into
mainfrom
fix/offer-list-disabled-expandable

Conversation

@lisalupi
Copy link
Copy Markdown
Collaborator

Summary

Type

  • Bug

Summarize concisely:

What is expected?

  • OfferList: disabled expand button on a row when expandable={false}
  • Update OfferList tests to use renderWithTheme instead of shouldMatchSnapshot (deprecated)

@lisalupi lisalupi requested a review from a team May 27, 2026 09:59
@lisalupi lisalupi self-assigned this May 27, 2026
@lisalupi lisalupi requested a review from jsulpis as a code owner May 27, 2026 09:59
@lisalupi lisalupi requested review from etienne-scaleway and vincentaudebert and removed request for a team May 27, 2026 09:59
@lisalupi lisalupi added the bug Something isn't working label May 27, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 27, 2026

🦋 Changeset detected

Latest commit: 4a94cc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.08%. Comparing base (8d278e6) to head (4a94cc9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6488      +/-   ##
==========================================
- Coverage   92.34%   92.08%   -0.27%     
==========================================
  Files         529      535       +6     
  Lines        9384     9575     +191     
  Branches     3465     3558      +93     
==========================================
+ Hits         8666     8817     +151     
- Misses        718      758      +40     
Files with missing lines Coverage Δ
...s/ui/src/compositions/OfferList/components/Row.tsx 95.52% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 900db9d...4a94cc9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/ui/src/compositions/OfferList/__tests__/index.test.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants