Skip to content

fix: remove small description on inputs#6492

Open
lisalupi wants to merge 1 commit into
mainfrom
fix/description-size
Open

fix: remove small description on inputs#6492
lisalupi wants to merge 1 commit into
mainfrom
fix/description-size

Conversation

@lisalupi
Copy link
Copy Markdown
Collaborator

Summary

Type

  • Bug

Summarize concisely:

What is expected?

Description: inputs should not use small description as it is hard to read

@lisalupi lisalupi requested review from a team and philibea May 27, 2026 14:38
@lisalupi lisalupi self-assigned this May 27, 2026
@lisalupi lisalupi requested a review from jsulpis as a code owner May 27, 2026 14:38
@lisalupi lisalupi requested review from DorianMaliszewski and removed request for a team May 27, 2026 14:38
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 27, 2026

🦋 Changeset detected

Latest commit: b9e8a4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.34%. Comparing base (8d278e6) to head (b9e8a4b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6492   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files         529      529           
  Lines        9384     9384           
  Branches     3465     3465           
=======================================
  Hits         8666     8666           
  Misses        718      718           
Files with missing lines Coverage Δ
packages/ui/src/components/FileInput/index.tsx 88.49% <100.00%> (ø)
packages/ui/src/components/NumberInput/index.tsx 97.77% <ø> (ø)
...ckages/ui/src/components/PhoneInput/PhoneInput.tsx 88.88% <ø> (ø)
packages/ui/src/components/SelectInput/index.tsx 100.00% <ø> (ø)
...tableCardOptionGroup/SelectableCardOptionGroup.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/TagInput/index.tsx 97.89% <ø> (ø)
packages/ui/src/components/TextInput/index.tsx 92.85% <ø> (ø)
packages/ui/src/components/TimeInput/index.tsx 97.20% <100.00%> (ø)
packages/ui/src/components/Toggle/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/UnitInput/index.tsx 98.07% <ø> (ø)
... and 1 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d278e6...b9e8a4b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@jsulpis jsulpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the change that we want precisely:

  1. the size prop of the Description component has no effect, or
  2. we don't want to apply it on the inputs ?

if it's 1. we should update the Description component so that the size has no effect (always use caption font), mark the size prop as deprecated and remove the stories, to avoid using it elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants