Skip to content

support new versionId format#2445

Merged
bert-e merged 2 commits intodevelopment/8.1from
bugfix/ARSN-502
Jul 21, 2025
Merged

support new versionId format#2445
bert-e merged 2 commits intodevelopment/8.1from
bugfix/ARSN-502

Conversation

@welansari
Copy link
Copy Markdown

@welansari welansari commented Jul 1, 2025

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 1, 2025

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 1, 2025

Incorrect fix version

The Fix Version/s in issue ARSN-502 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.2.25

Please check the Fix Version/s of ARSN-502, or the target
branch of this pull request.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 1, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.40%. Comparing base (b0cd656) to head (a8517be).
Report is 2 commits behind head on development/8.1.

Files with missing lines Patch % Lines
lib/versioning/VersionID.ts 94.59% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/8.1    #2445      +/-   ##
===================================================
+ Coverage            69.37%   69.40%   +0.03%     
===================================================
  Files                  220      220              
  Lines                17787    17811      +24     
  Branches              3629     3634       +5     
===================================================
+ Hits                 12339    12362      +23     
- Misses                5432     5433       +1     
  Partials                16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@welansari welansari requested review from a user and jonathan-gramain July 1, 2025 17:05
@welansari welansari marked this pull request as ready for review July 2, 2025 09:01
@welansari welansari changed the base branch from development/8.2 to development/8.1 July 2, 2025 09:01
@scality scality deleted a comment from bert-e Jul 2, 2025
@scality scality deleted a comment from bert-e Jul 2, 2025
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 2, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

Comment thread lib/versioning/VersionID.ts Outdated
Comment thread lib/versioning/VersioningRequestProcessor.ts Outdated
Comment thread lib/versioning/VersioningRequestProcessor.ts Outdated
Comment thread lib/versioning/VersionID.ts Outdated
Comment thread lib/versioning/VersionID.ts Outdated
Comment thread lib/versioning/VersionID.ts Outdated
Comment thread lib/versioning/VersionID.ts Outdated
Comment thread lib/versioning/VersionID.ts Outdated
Comment thread lib/versioning/VersionID.ts Outdated
Comment thread lib/versioning/VersionID.ts Outdated
Comment thread lib/storage/metadata/mongoclient/MongoClientInterface.ts Outdated
@welansari welansari force-pushed the bugfix/ARSN-502 branch 7 times, most recently from 23d8575 to 0c43d0a Compare July 15, 2025 14:33
export const VersioningConstants = {
VersionId: {
Separator: '\0',
FormatMarker: '?',
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers:

I updated the versionID format marker from the record separator control character (\x1E) to ? for better compatibility and performance. This way we avoid having to parse the versionID every time we read it from the DB.

The ? character is safe to use because it never appears in the info section of existing hex-encoded versionIDs. In both our metadata implementations, the info field contains only numeric values and basic punctuation:

Metadata: ${info.term}.${info.aseq}.${this.uidCounter++}
MongoDB: ${process.pid}.${uidCounter++}

Also, the new versionID format is disabled by default, this will allow keeping the same branches and decide when to enabled it through feature flags or other means.

Comment thread lib/versioning/VersionID.ts Outdated
Comment thread lib/versioning/VersionID.ts Outdated
Comment thread lib/versioning/VersionID.ts Outdated
Comment thread lib/versioning/VersionID.ts Outdated
Comment thread lib/versioning/VersionID.ts Outdated
@welansari welansari force-pushed the bugfix/ARSN-502 branch 3 times, most recently from 07ab7c8 to bb9b416 Compare July 21, 2025 08:56
@welansari
Copy link
Copy Markdown
Author

/create_integration_branches

@scality scality deleted a comment from bert-e Jul 21, 2025
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 21, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@welansari
Copy link
Copy Markdown
Author

/reset

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 21, 2025

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

@scality scality deleted a comment from bert-e Jul 21, 2025
@scality scality deleted a comment from bert-e Jul 21, 2025
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 21, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@welansari
Copy link
Copy Markdown
Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 21, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

  • ✔️ development/8.2

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70

Please check the status of the associated issue ARSN-502.

Goodbye kerkesni.

The following options are set: approve, create_integration_branches

@bert-e bert-e merged commit a8517be into development/8.1 Jul 21, 2025
7 checks passed
@bert-e bert-e deleted the bugfix/ARSN-502 branch July 21, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants