support new versionId format#2445
Conversation
Hello kerkesni,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
929396c to
b52a8da
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development/8.1 #2445 +/- ##
===================================================
+ Coverage 69.37% 69.40% +0.03%
===================================================
Files 220 220
Lines 17787 17811 +24
Branches 3629 3634 +5
===================================================
+ Hits 12339 12362 +23
- Misses 5432 5433 +1
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b52a8da to
d462812
Compare
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
d462812 to
98bebdf
Compare
23d8575 to
0c43d0a
Compare
| export const VersioningConstants = { | ||
| VersionId: { | ||
| Separator: '\0', | ||
| FormatMarker: '?', |
There was a problem hiding this comment.
Note for reviewers:
I updated the versionID format marker from the record separator control character (\x1E) to ? for better compatibility and performance. This way we avoid having to parse the versionID every time we read it from the DB.
The ? character is safe to use because it never appears in the info section of existing hex-encoded versionIDs. In both our metadata implementations, the info field contains only numeric values and basic punctuation:
Metadata: ${info.term}.${info.aseq}.${this.uidCounter++}
MongoDB: ${process.pid}.${uidCounter++}
Also, the new versionID format is disabled by default, this will allow keeping the same branches and decide when to enabled it through feature flags or other means.
07ab7c8 to
bb9b416
Compare
|
/create_integration_branches |
bb9b416 to
dd9e980
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
|
/reset |
Reset completeI have successfully deleted this pull request's integration branches. The following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-502. Goodbye kerkesni. The following options are set: approve, create_integration_branches |
see https://scality.atlassian.net/wiki/spaces/OS/pages/3225583692/VersionID+Collisions+in+Zenko
Related PR: scality/cloudserver#5826
Issue: ARSN-502