-
Notifications
You must be signed in to change notification settings - Fork 255
Expand file tree
/
Copy pathobjectDelete.js
More file actions
324 lines (307 loc) · 14.6 KB
/
objectDelete.js
File metadata and controls
324 lines (307 loc) · 14.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
/* eslint-disable indent */
const async = require('async');
const { errors, versioning, s3middleware } = require('arsenal');
const checkDateModifiedHeaders = s3middleware.checkDateModifiedHeaders;
const collectCorsHeaders = require('../utilities/collectCorsHeaders');
const services = require('../services');
const { pushMetric } = require('../utapi/utilities');
const createAndStoreObject = require('./apiUtils/object/createAndStoreObject');
const { decodeVersionId, preprocessingVersioningDelete }
= require('./apiUtils/object/versioning');
const { standardMetadataValidateBucketAndObj } = require('../metadata/metadataUtils');
const monitoring = require('../utilities/monitoringHandler');
const { hasGovernanceBypassHeader, ObjectLockInfo }
= require('./apiUtils/object/objectLockHelpers');
const { config } = require('../Config');
const { _bucketRequiresOplogUpdate } = require('./apiUtils/object/deleteObject');
const versionIdUtils = versioning.VersionID;
const objectLockedError = new Error('object locked');
const { overheadField } = require('../../constants');
/**
* objectDeleteInternal - DELETE an object from a bucket
* @param {AuthInfo} authInfo - requester's infos
* @param {object} request - request object given by router,
* includes normalized headers
* @param {Logger} log - werelogs request instance
* @param {boolean} isExpiration - true if the call comes from LifecycleExpiration
* @param {function} cb - final cb to call with the result and response headers
* @return {undefined}
*/
function objectDeleteInternal(authInfo, request, log, isExpiration, cb) {
log.debug('processing request', { method: 'objectDeleteInternal' });
if (authInfo.isRequesterPublicUser()) {
log.debug('operation not available for public user');
monitoring.promMetrics(
'DELETE', request.bucketName, 403, 'deleteObject');
return cb(errors.AccessDenied);
}
const bucketName = request.bucketName;
const objectKey = request.objectKey;
const decodedVidResult = decodeVersionId(request.query);
if (decodedVidResult instanceof Error) {
log.trace('invalid versionId query', {
versionId: request.query.versionId,
error: decodedVidResult,
});
return cb(decodedVidResult);
}
const reqVersionId = decodedVidResult;
const hasGovernanceBypass = hasGovernanceBypassHeader(request.headers);
const valParams = {
authInfo,
bucketName,
objectKey,
versionId: reqVersionId,
requestType: request.apiMethods || 'objectDelete',
request,
};
const canonicalID = authInfo.getCanonicalID();
return async.waterfall([
function validateBucketAndObj(next) {
return standardMetadataValidateBucketAndObj(valParams, request.actionImplicitDenies, log,
(err, bucketMD, objMD) => {
if (err) {
return next(err, bucketMD);
}
const versioningCfg = bucketMD.getVersioningConfiguration();
if (!objMD) {
if (!versioningCfg) {
return next(errors.NoSuchKey, bucketMD);
}
// AWS does not return an error when trying to delete a
// specific version that does not exist. We skip to the end
// of the waterfall here.
if (reqVersionId) {
log.debug('trying to delete specific version ' +
' that does not exist');
return next(errors.NoSuchVersion, bucketMD);
}
// To adhere to AWS behavior, create a delete marker even
// if trying to delete an object that does not exist when
// versioning has been configured
return next(null, bucketMD, objMD);
}
if (versioningCfg && versioningCfg.Status === 'Enabled' &&
objMD.versionId === reqVersionId && isExpiration &&
!objMD.isDeleteMarker) {
log.warn('expiration is trying to delete a master version ' +
'of an object with versioning enabled', {
method: 'objectDeleteInternal',
isExpiration,
reqVersionId,
versionId: objMD.versionId,
replicationState: objMD.replicationInfo,
location: objMD.location,
originOp: objMD.originOp,
});
}
if (reqVersionId && objMD.location &&
Array.isArray(objMD.location) && objMD.location[0]) {
// we need this information for data deletes to AWS
// eslint-disable-next-line no-param-reassign
objMD.location[0].deleteVersion = true;
}
if (objMD['content-length'] !== undefined) {
log.end().addDefaultFields({
bytesDeleted: objMD['content-length'],
});
}
return next(null, bucketMD, objMD);
});
},
function evaluateObjectLockPolicy(bucketMD, objectMD, next) {
// AWS only returns an object lock error if a version id
// is specified, else continue to create a delete marker
if (!reqVersionId) {
return next(null, bucketMD, objectMD);
}
const objLockInfo = new ObjectLockInfo({
mode: objectMD.retentionMode,
date: objectMD.retentionDate,
legalHold: objectMD.legalHold || false,
});
// If the object can not be deleted raise an error
if (!objLockInfo.canModifyObject(hasGovernanceBypass)) {
log.debug('trying to delete locked object');
return next(objectLockedError, bucketMD);
}
return next(null, bucketMD, objectMD);
},
function validateHeaders(bucketMD, objectMD, next) {
if (objectMD) {
const lastModified = objectMD['last-modified'];
const { modifiedSinceRes, unmodifiedSinceRes } =
checkDateModifiedHeaders(request.headers, lastModified);
const err = modifiedSinceRes.error || unmodifiedSinceRes.error;
if (err) {
return process.nextTick(() => next(err, bucketMD));
}
}
return process.nextTick(() =>
next(null, bucketMD, objectMD));
},
function deleteOperation(bucketMD, objectMD, next) {
const delOptions = preprocessingVersioningDelete(
bucketName, bucketMD, objectMD, reqVersionId, config.nullVersionCompatMode);
const deleteInfo = {
removeDeleteMarker: false,
newDeleteMarker: false,
};
if (delOptions && delOptions.deleteData && bucketMD.isNFS() &&
bucketMD.getReplicationConfiguration()) {
// If an NFS bucket that has replication configured, we want
// to put a delete marker on the destination even though the
// source does not have versioning.
return createAndStoreObject(bucketName, bucketMD, objectKey,
objectMD, authInfo, canonicalID, null, request, true, null,
log, isExpiration ?
's3:LifecycleExpiration:DeleteMarkerCreated' :
's3:ObjectRemoved:DeleteMarkerCreated',
err => {
if (err) {
return next(err);
}
if (objectMD.isDeleteMarker) {
// record that we deleted a delete marker to set
// response headers accordingly
deleteInfo.removeDeleteMarker = true;
}
return services.deleteObject(bucketName, objectMD,
objectKey, delOptions, false, log, isExpiration ?
's3:LifecycleExpiration:Delete' :
's3:ObjectRemoved:Delete',
(err, delResult) =>
next(err, bucketMD, objectMD, delResult, deleteInfo));
});
}
if (delOptions && delOptions.deleteData) {
delOptions.overheadField = overheadField;
if (objectMD.isDeleteMarker) {
// record that we deleted a delete marker to set
// response headers accordingly
deleteInfo.removeDeleteMarker = true;
}
if (objectMD.uploadId) {
// eslint-disable-next-line
delOptions.replayId = objectMD.uploadId;
}
if (!_bucketRequiresOplogUpdate(bucketMD)) {
delOptions.doesNotNeedOpogUpdate = true;
}
return services.deleteObject(bucketName, objectMD, objectKey,
delOptions, false, log, isExpiration ?
's3:LifecycleExpiration:Delete' :
's3:ObjectRemoved:Delete',
(err, delResult) => next(err, bucketMD,
objectMD, delResult, deleteInfo));
}
// putting a new delete marker
deleteInfo.newDeleteMarker = true;
return createAndStoreObject(bucketName, bucketMD,
objectKey, objectMD, authInfo, canonicalID, null, request,
deleteInfo.newDeleteMarker, null, overheadField, log, isExpiration ?
's3:LifecycleExpiration:DeleteMarkerCreated' :
's3:ObjectRemoved:DeleteMarkerCreated',
(err, newDelMarkerRes) => {
next(err, bucketMD, objectMD, newDelMarkerRes, deleteInfo);
});
},
], (err, bucketMD, objectMD, result, deleteInfo) => {
const resHeaders = collectCorsHeaders(request.headers.origin,
request.method, bucketMD);
// if deleting a specific version or delete marker, return version id
// in the response headers, even in case of NoSuchVersion
if (reqVersionId) {
resHeaders['x-amz-version-id'] = reqVersionId === 'null' ?
reqVersionId : versionIdUtils.encode(reqVersionId);
if (deleteInfo && deleteInfo.removeDeleteMarker) {
resHeaders['x-amz-delete-marker'] = true;
}
}
if (err === objectLockedError) {
log.debug('preventing deletion due to object lock',
{
error: errors.AccessDenied,
objectLocked: true,
method: 'objectDelete',
});
return cb(errors.AccessDenied, resHeaders);
}
if (err) {
log.debug('error processing request', { error: err,
method: 'objectDelete' });
monitoring.promMetrics(
'DELETE', bucketName, err.code, 'deleteObject');
return cb(err, resHeaders);
}
if (deleteInfo.newDeleteMarker) {
// if we created a new delete marker, return true for
// x-amz-delete-marker and the version ID of the new delete marker
if (result.versionId) {
resHeaders['x-amz-delete-marker'] = true;
resHeaders['x-amz-version-id'] = result.versionId === 'null' ?
result.versionId : versionIdUtils.encode(result.versionId);
}
/* byteLength is passed under the following conditions:
* - bucket versioning is suspended
* - object version id is null
* and one of:
* - the content length of the object exists
* - or -
* - it is a delete marker
* In this case, the master key is deleted and replaced with a delete marker.
* The decrement accounts for the deletion of the master key when utapi reports
* on the number of objects.
*/
// FIXME: byteLength may be incorrect, see S3C-7440
const versioningSuspended = bucketMD.getVersioningConfiguration()
&& bucketMD.getVersioningConfiguration().Status === 'Suspended';
const deletedSuspendedMasterVersion = versioningSuspended && !!objectMD;
// Default to 0 content-length to cover deleting a DeleteMarker
const objectByteLength = (objectMD && objectMD['content-length']) || 0;
const byteLength = deletedSuspendedMasterVersion ? Number.parseInt(objectByteLength, 10) : null;
pushMetric('putDeleteMarkerObject', log, {
authInfo,
byteLength,
bucket: bucketName,
keys: [objectKey],
versionId: result.versionId,
location: objectMD ? objectMD.dataStoreName : undefined,
});
} else {
log.end().addDefaultFields({
contentLength: objectMD['content-length'],
});
pushMetric('deleteObject', log, {
authInfo,
canonicalID: bucketMD.getOwner(),
bucket: bucketName,
keys: [objectKey],
byteLength: Number.parseInt(objectMD['content-length'], 10),
numberOfObjects: 1,
location: objectMD.dataStoreName,
isDelete: true,
});
monitoring.promMetrics('DELETE', bucketName, '200', 'deleteObject',
Number.parseInt(objectMD['content-length'], 10));
}
return cb(err, resHeaders);
});
}
/**
* This function is used to delete an object from a bucket. The bucket must
* already exist and the user must have permission to delete the object.
* @param {AuthInfo} authInfo - Instance of AuthInfo class with requester's info
* @param {object} request - http request object
* @param {werelogs.Logger} log - Logger object
* @param {function} cb - callback to server
* @return {undefined}
*/
function objectDelete(authInfo, request, log, cb) {
log.debug('processing request', { method: 'objectDelete' });
return objectDeleteInternal(authInfo, request, log, false, cb);
}
module.exports = {
objectDelete,
objectDeleteInternal,
};