CLDSRV-835: Improve bucket utility empty function

No need to separate trailing slash keys.
Use multi object delete instead of parallel single delete
List all pagination

Author: BourgoisMickael

tests/functional/aws-node-sdk/lib/utility/bucket-util.js

@@ -4,7 +4,7 @@ const {
     CreateBucketCommand,
     DeleteBucketCommand,
     ListObjectVersionsCommand,
-    DeleteObjectCommand,
+    DeleteObjectsCommand,
     ListBucketsCommand,
 } = require('@aws-sdk/client-s3');
 const projectFixture = require('../fixtures/project');
@@ -90,48 +90,49 @@ class BucketUtility {
      * @param bucketName
      * @returns {Promise.<T>}
      */
-    empty(bucketName, BypassGovernanceRetention = false) {
-        const param = {
-            Bucket: bucketName,
-        };
-
-        return this.s3.send(new ListObjectVersionsCommand(param))
-            .then(data => Promise.all(
-                (data.Versions || [])
-                .filter(object => !object.Key.endsWith('/'))
-                .map(object =>
-                    this.s3.send(new DeleteObjectCommand({
-                        Bucket: bucketName,
-                        Key: object.Key,
-                        VersionId: object.VersionId,
-                        ...(BypassGovernanceRetention && { BypassGovernanceRetention }),
-                    })).then(() => object)
-                )
-                .concat((data.Versions || [])
-                    .filter(object => object.Key.endsWith('/'))
-                    .map(object =>
-                        this.s3.send(new DeleteObjectCommand({
-                            Bucket: bucketName,
-                            Key: object.Key,
-                            VersionId: object.VersionId,
-                            ...(BypassGovernanceRetention && { BypassGovernanceRetention }),
-                        }))
-                        .then(() => object)
-                    )
-                )
-                .concat((data.DeleteMarkers || [])
-                    .map(object =>
-                    this.s3.send(new DeleteObjectCommand({
-                        Bucket: bucketName,
-                        Key: object.Key,
-                        VersionId: object.VersionId,
-                        ...(BypassGovernanceRetention && { BypassGovernanceRetention }),
-                        }))
-                        .then(() => object)
-                    )
-                )
-            )
-        );
+    async empty(bucketName, BypassGovernanceRetention = false) {
+        let keyMarker = undefined;
+        let versionIdMarker = undefined;
+        let isTruncated = true;
+
+        while (isTruncated) {
+            const response = await this.s3.send(new ListObjectVersionsCommand({
+                Bucket: bucketName,
+                KeyMarker: keyMarker,
+                VersionIdMarker: versionIdMarker,
+            }));
+
+            const objects = [
+                ...(response.Versions || []),
+                ...(response.DeleteMarkers || []),
+            ].map(({ Key, VersionId }) => ({ Key, VersionId }));
+
+            if (objects.length > 0) {
+                const result = await this.s3.send(new DeleteObjectsCommand({
+                    Bucket: bucketName,
+                    Delete: {
+                        Objects: objects,
+                        Quiet: true
+                    },
+                    ...(BypassGovernanceRetention && { BypassGovernanceRetention }),
+                }));
+                if (result.Errors && result.Errors.length > 0) {
+                    for (const e of result.Errors) {
+                        // eslint-disable-next-line no-console
+                        console.warn(
+                            `Warning BucketUtility.empty(): failed to delete s3://${bucketName}/${e.Key}` +
+                            ` (versionId=${e.VersionId}): ${e.Code} - ${e.Message}`
+                        );
+                    }
+                }
+            }
+
+            isTruncated = response.IsTruncated;
+            if (isTruncated) {
+                keyMarker = response.NextKeyMarker;
+                versionIdMarker = response.NextVersionIdMarker;
+            }
+        }
     }
 
     emptyMany(bucketNames) {