Upgrade supportedLifecycleRules definition

Use the values and "format" defined in arsenal, i.e. the names from S3.
This simplifies code and avoids duplication.

Issue: CLDSRV-651

Author: francoisferrand

constants.js

@@ -250,13 +250,6 @@ const constants = {
     // if requester is not bucket owner, bucket policy actions should be denied with
     // MethodNotAllowed error
     onlyOwnerAllowed: ['bucketDeletePolicy', 'bucketGetPolicy', 'bucketPutPolicy'],
-    supportedLifecycleRules: [
-        'expiration',
-        'noncurrentVersionExpiration',
-        'abortIncompleteMultipartUpload',
-        'transitions',
-        'noncurrentVersionTransition',
-    ],
 };
 
 module.exports = constants;

lib/Config.js

@@ -18,8 +18,8 @@ const {
     base64Regex,
     allowedUtapiEventFilterFields,
     allowedUtapiEventFilterStates,
-    supportedLifecycleRules,
 } = require('../constants');
+const { ValidLifecycleRules: supportedLifecycleRules } = require('arsenal').models;
 const { utapiVersion } = require('utapi');
 const { scaleMsPerDay } = s3middleware.objectUtils;
 

tests/unit/Config.js

@@ -9,9 +9,7 @@ const {
     ConfigObject,
 } = require('../../lib/Config');
 
-const {
-    supportedLifecycleRules,
-} = require('../../constants');
+const { ValidLifecycleRules: supportedLifecycleRules } = require('arsenal').models;
 
 describe('Config', () => {
     const envToRestore = [];
@@ -673,9 +671,9 @@ describe('Config', () => {
 
         it('should return the rules provided when they are valid', () => {
             const rules = [
-                'expiration',
-                'noncurrentVersionExpiration',
-                'abortIncompleteMultipartUpload',
+                'Expiration',
+                'NoncurrentVersionExpiration',
+                'AbortIncompleteMultipartUpload',
             ];
             const parsedRules = parseSupportedLifecycleRules(rules);
             assert.deepStrictEqual(parsedRules, rules);