Skip to content

Commit 0db289f

Browse files
committed
Merge remote-tracking branch 'origin/improvement/CLDSRV-843' into w/9.3/improvement/CLDSRV-843
2 parents 45ef2f0 + 1af3942 commit 0db289f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

lib/utilities/serverAccessLogger.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@ function buildLogEntry(req, params, options) {
482482
turnAroundTime: options.turnAroundTime ?? undefined,
483483
referer: options.referer ?? undefined,
484484
userAgent: options.userAgent ?? undefined,
485-
versionID: options.versionID ?? undefined,
485+
versionId: options.versionId ?? undefined,
486486
signatureVersion: authInfo?.getAuthVersion() ?? undefined,
487487
cipherSuite: req.socket?.encrypted ? req.socket.getCipher()['standardName'] : undefined,
488488
authenticationType: authInfo?.getAuthType() ?? undefined,
@@ -581,7 +581,7 @@ function logServerAccess(req, res) {
581581
objectSize: params.objectSize ?? getObjectSize(req, res),
582582
totalTime: calculateTotalTime(params.startTime, params.onFinishEndTime),
583583
turnAroundTime: calculateTurnAroundTime(params.startTurnAroundTime, endTurnAroundTime),
584-
versionID: req.query?.versionId,
584+
versionId: req.query?.versionId,
585585
aclRequired: undefined, // TODO: CLDSRV-774
586586
referer: req.headers?.referer,
587587
userAgent: req.headers?.['user-agent'],

tests/unit/utils/serverAccessLogger.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -884,7 +884,7 @@ describe('serverAccessLogger utility functions', () => {
884884
assert.strictEqual(loggedData.turnAroundTime, '1');
885885
assert.strictEqual(loggedData.referer, 'https://example.com');
886886
assert.strictEqual(loggedData.userAgent, 'aws-cli/2.0.0');
887-
assert.strictEqual(loggedData.versionID, 'version123');
887+
assert.strictEqual(loggedData.versionId, 'version123');
888888
assert.strictEqual(loggedData.signatureVersion, 'AWS4-HMAC-SHA256');
889889
assert.strictEqual(loggedData.cipherSuite, 'TLS_AES_128_GCM_SHA256');
890890
assert.strictEqual(loggedData.authenticationType, 'REST-HEADER');
@@ -996,7 +996,7 @@ describe('serverAccessLogger utility functions', () => {
996996

997997
assert.strictEqual(mockLogger.write.callCount, 1);
998998
const loggedData = JSON.parse(mockLogger.write.firstCall.args[0].trim());
999-
assert.strictEqual('versionID' in loggedData, false);
999+
assert.strictEqual('versionId' in loggedData, false);
10001000
});
10011001

10021002
it('should handle loggingEnabled without TargetBucket/TargetPrefix', () => {
@@ -1099,7 +1099,7 @@ describe('serverAccessLogger utility functions', () => {
10991099
assert.strictEqual('bytesDeleted' in loggedData, false);
11001100
assert.strictEqual('turnAroundTime' in loggedData, false);
11011101
assert.strictEqual('referer' in loggedData, false);
1102-
assert.strictEqual('versionID' in loggedData, false);
1102+
assert.strictEqual('versionId' in loggedData, false);
11031103
assert.strictEqual('cipherSuite' in loggedData, false);
11041104
assert.strictEqual('tlsVersion' in loggedData, false);
11051105
assert.strictEqual('aclRequired' in loggedData, false);

0 commit comments

Comments
 (0)