do not allow using crr location as a locationConstraint

Issue: CLDSRV-653

Author: Kerkesni

lib/Config.js

@@ -305,7 +305,7 @@ function hdClientLocationConstraintAssert(configHd) {
 
 function locationConstraintAssert(locationConstraints) {
     const supportedBackends = [
-        'mem', 'file', 'scality', 'mongodb', 'tlp',
+        'mem', 'file', 'scality', 'mongodb', 'tlp', 'crr'
     ].concat(Object.keys(validExternalBackends));
     assert(typeof locationConstraints === 'object',
         'bad config: locationConstraints must be an object');

lib/api/bucketPut.js

@@ -59,7 +59,8 @@ function checkLocationConstraint(request, locationConstraint, log) {
         return { error: errorInstances.InvalidLocationConstraint.
             customizeDescription(errMsg) };
     }
-    if (locationConstraints[locationConstraintChecked].isCold) {
+    if (locationConstraints[locationConstraintChecked].isCold ||
+        locationConstraints[locationConstraintChecked].type === 'crr') {
         return { error: errors.InvalidLocationConstraint };
     }
     if (locationConstraintAddon) {

locationConfig.json

@@ -108,5 +108,11 @@
         "legacyAwsBehavior": false,
         "isCold": true,
         "details": {}
+    },
+    "location-crr-v1": {
+        "type": "crr",
+        "objectId": "location-crr-v1",
+        "legacyAwsBehavior": false,
+        "details": {}
     }
 }

tests/locationConfig/locationConfigCeph.json

@@ -263,5 +263,11 @@
         "legacyAwsBehavior": false,
         "isCold": true,
         "details": {}
+    },
+    "location-crr-v1": {
+        "type": "crr",
+        "objectId": "location-crr-v1",
+        "legacyAwsBehavior": false,
+        "details": {}
     }
 }

tests/locationConfig/locationConfigLegacy.json

@@ -185,5 +185,11 @@
         "legacyAwsBehavior": false,
         "isCold": true,
         "details": {}
+    },
+    "location-crr-v1": {
+        "type": "crr",
+        "objectId": "location-crr-v1",
+        "legacyAwsBehavior": false,
+        "details": {}
     }
 }

tests/locationConfig/locationConfigTests.json

@@ -274,5 +274,11 @@
         "legacyAwsBehavior": false,
         "isCold": true,
         "details": {}
+    },
+    "location-crr-v1": {
+        "type": "crr",
+        "objectId": "location-crr-v1",
+        "legacyAwsBehavior": false,
+        "details": {}
     }
 }

tests/unit/api/bucketGetLocation.js

@@ -47,8 +47,8 @@ describe('getBucketLocation API', () => {
             // see next test.
             return;
         }
-        if (location === 'location-dmf-v1') {
-            // if region location-dmf-v1 should return InvalidLocationConstraint error
+        if (location === 'location-dmf-v1' || location === 'location-crr-v1') {
+            // if region location-dmf-v1 or location-crr-v1 should return InvalidLocationConstraint error
             return;
         }
         const bucketPutRequest = getBucketRequestObject(location);

tests/unit/api/bucketPut.js

@@ -78,6 +78,14 @@ const testChecks = [
         isError: true,
         expectedError: 'InvalidLocationConstraint',
     },
+    {
+        data: 'multiple',
+        locationSent: 'location-crr-v1',
+        parsedHost: '127.3.2.1',
+        locationReturn: 'location-crr-v1',
+        isError: true,
+        expectedError: 'InvalidLocationConstraint',
+    },
 ];
 
 describe('checkLocationConstraint function', () => {
@@ -376,6 +384,27 @@ describe('bucketPut API', () => {
         });
     });
 
+    it('should deny put bucket if locationConstraint is the crr location', done => {
+        const bucketName = 'bucket-name';
+        const newRestEndpoint = 'location-crr-v1';
+        const location = 'location-crr-v1';
+
+        const req = {
+            ...testRequest,
+            parsedHost: newRestEndpoint,
+            bucketName,
+        };
+
+        const newRestEndpoints = Object.assign({}, config.restEndpoints);
+        newRestEndpoints[newRestEndpoint] = location;
+        config.setRestEndpoints(newRestEndpoints);
+
+        bucketPut(authInfo, req, log, err => {
+            assert.strictEqual(err.is.InvalidLocationConstraint, true);
+            done();
+        });
+    });
+
     describe('Config::setLocationConstraints', () => {
         const bucketName = `test-bucket-${Date.now()}`;
         const newLC = {};

tests/unit/testConfigs/locConstraintAssert.js

@@ -56,14 +56,14 @@ describe('locationConstraintAssert', () => {
         /bad config: locationConstraints[region].type is mandatory/ +
             /and must be a string/);
     });
-    it('should throw error if type is not mem/file/scality/dmf', () => {
+    it('should throw error if type is not mem/file/scality/dmf/crr', () => {
         const locationConstraint = new LocationConstraint(
             'notSupportedType', 'locId');
         assert.throws(() => {
             locationConstraintAssert({ 'scality-east': locationConstraint });
         },
         /bad config: locationConstraints[region].type must be/ +
-            /one of mem,file,scality,tlp/);
+            /one of mem,file,scality,tlp,crr/);
     });
     it('should throw error if legacyAwsBehavior is not a boolean', () => {
         const locationConstraint = new LocationConstraint(