do not allow crr location as an object locationConstraint

Issue: CLDSRV-653

Author: Kerkesni

lib/api/objectCopy.js

@@ -130,7 +130,7 @@ function _prepMetadata(request, sourceObjMD, headers, sourceIsDestination,
     const backendInfoObjDest = locationConstraintCheck(request,
         userMetadata, destBucketMD, log);
     if (backendInfoObjDest.err) {
-        return { error: backendInfoObjSource.err };
+        return { error: backendInfoObjDest.err };
     }
     const destLocationConstraintName = backendInfoObjDest.controllingLC;
 

package.json

@@ -21,7 +21,7 @@
   "dependencies": {
     "@azure/storage-blob": "^12.25.0",
     "@hapi/joi": "^17.1.1",
-    "arsenal": "git+https://github.com/scality/Arsenal#8.2.18",
+    "arsenal": "git+https://github.com/scality/Arsenal#c102852d95d5ac91fd726d9f37a4faaf65ed6443",
     "async": "2.6.4",
     "aws-sdk": "^2.1692.0",
     "bucketclient": "scality/bucketclient#8.2.4",

tests/unit/api/multipartUpload.js

@@ -2174,6 +2174,32 @@ describe('Multipart Upload API', () => {
             },
         ], done);
     });
+
+    it('should fail to initiate a multipart upload if location constraint is crr', done => {
+        const initiateRequest = {
+            socket: {
+                remoteAddress: '1.1.1.1',
+            },
+            bucketName,
+            namespace,
+            objectKey,
+            headers: {
+                host: `${bucketName}.s3.amazonaws.com`,
+                [constants.objectLocationConstraintHeader]: 'location-crr-v1',
+            },
+            url: `/${objectKey}?uploads`,
+            actionImplicitDenies: false,
+        };
+
+        bucketPut(authInfo, bucketPutRequest, log, err => {
+            assert.ifError(err);
+            initiateMultipartUpload(authInfo, initiateRequest,
+                log, err => {
+                    assert(err.is.InvalidArgument);
+                    done();
+                });
+        });
+    });
 });
 
 describe('complete mpu with versioning', () => {

tests/unit/api/objectCopy.js

@@ -39,12 +39,12 @@ function _createBucketPutRequest(bucketName) {
     });
 }
 
-function _createObjectCopyRequest(destBucketName) {
+function _createObjectCopyRequest(destBucketName, headers = {}) {
     const params = {
         bucketName: destBucketName,
         namespace,
         objectKey,
-        headers: {},
+        headers,
         url: `/${destBucketName}/${objectKey}`,
         socket: {},
     };
@@ -231,6 +231,7 @@ describe('non-versioned objectCopy', () => {
         cleanup();
         sinon.stub(metadata, 'putObjectMD')
             .callsFake(originalputObjectMD);
+
         async.series([
             callback => bucketPut(authInfo, putDestBucketRequest, log,
                 callback),
@@ -338,6 +339,22 @@ describe('non-versioned objectCopy', () => {
             },
         ], done);
     });
+
+    it('should fail to copy object when setting a crr location as the locationConstraint', done => {
+        const testObjectCopyRequest = _createObjectCopyRequest(destBucketName, {
+            'x-amz-metadata-directive': 'REPLACE', // needed to take the locationConstraint into account
+            [objectLocationConstraintHeader]: 'location-crr-v1',
+        });
+
+        async.series([
+            next => objectPut(authInfo, testPutDestObjectRequest, undefined, log, next),
+            next => objectCopy(authInfo, testObjectCopyRequest, sourceBucketName, objectKey,
+                undefined, log, next),
+        ], err => {
+            assert(err.is.InvalidArgument);
+            done();
+        });
+    });
 });
 
 describe('objectCopy overheadField', () => {

tests/unit/api/objectPut.js

@@ -843,6 +843,27 @@ describe('objectPut API', () => {
             });
         });
     });
+
+    it('should fail to put object when setting a crr location as the locationConstraint', done => {
+        const testPutObjectRequest = new DummyRequest({
+            bucketName,
+            namespace,
+            objectKey: objectName,
+            headers: {
+                [objectLocationConstraintHeader]: 'location-crr-v1',
+            },
+            url: `/${bucketName}/${objectName}`,
+            calculatedHash: 'vnR+tLdVF79rPPfF+7YvOg==',
+        }, postBody);
+
+        bucketPut(authInfo, testPutBucketRequest, log, () => {
+            objectPut(authInfo, testPutObjectRequest, undefined, log,
+                err => {
+                    assert(err.is.InvalidArgument);
+                    done();
+                });
+        });
+    });
 });
 
 describe('objectPut API with versioning', () => {

yarn.lock

@@ -173,10 +173,10 @@
     fast-xml-parser "^5.0.7"
     tslib "^2.8.1"
 
-"@azure/identity@^4.5.0":
-  version "4.8.0"
-  resolved "https://registry.yarnpkg.com/@azure/identity/-/identity-4.8.0.tgz#686682683a470ccf4dbb2597ee234f9c5c483a40"
-  integrity sha512-l9ALUGHtFB/JfsqmA+9iYAp2a+cCwdNO/cyIr2y7nJLJsz1aae6qVP8XxT7Kbudg0IQRSIMXj0+iivFdbD1xPA==
+"@azure/identity@^4.10.0":
+  version "4.10.0"
+  resolved "https://registry.yarnpkg.com/@azure/identity/-/identity-4.10.0.tgz#10cfe49207b4d111ebe3aab3ade47561c2852c6d"
+  integrity sha512-iT53Sre2NJK6wzMWnvpjNiR3md597LZ3uK/5kQD2TkrY9vqhrY5bt2KwELNjkOWQ9n8S/92knj/QEykTtjMNqQ==
   dependencies:
     "@azure/abort-controller" "^2.0.0"
     "@azure/core-auth" "^1.9.0"
@@ -186,17 +186,14 @@
     "@azure/core-util" "^1.11.0"
     "@azure/logger" "^1.0.0"
     "@azure/msal-browser" "^4.2.0"
-    "@azure/msal-node" "^3.2.3"
-    events "^3.0.0"
-    jws "^4.0.0"
+    "@azure/msal-node" "^3.5.0"
     open "^10.1.0"
-    stoppable "^1.1.0"
     tslib "^2.2.0"
 
-"@azure/identity@^4.9.1":
-  version "4.9.1"
-  resolved "https://registry.yarnpkg.com/@azure/identity/-/identity-4.9.1.tgz#ee4b9435f1b96bea5985e7dec989760a67d9a119"
-  integrity sha512-986D7Cf1AOwYqSDtO/FnMAyk/Jc8qpftkGsxuehoh4F85MhQ4fICBGX/44+X1y78lN4Sqib3Bsoaoh/FvOGgmg==
+"@azure/identity@^4.5.0":
+  version "4.8.0"
+  resolved "https://registry.yarnpkg.com/@azure/identity/-/identity-4.8.0.tgz#686682683a470ccf4dbb2597ee234f9c5c483a40"
+  integrity sha512-l9ALUGHtFB/JfsqmA+9iYAp2a+cCwdNO/cyIr2y7nJLJsz1aae6qVP8XxT7Kbudg0IQRSIMXj0+iivFdbD1xPA==
   dependencies:
     "@azure/abort-controller" "^2.0.0"
     "@azure/core-auth" "^1.9.0"
@@ -206,8 +203,11 @@
     "@azure/core-util" "^1.11.0"
     "@azure/logger" "^1.0.0"
     "@azure/msal-browser" "^4.2.0"
-    "@azure/msal-node" "^3.5.0"
+    "@azure/msal-node" "^3.2.3"
+    events "^3.0.0"
+    jws "^4.0.0"
     open "^10.1.0"
+    stoppable "^1.1.0"
     tslib "^2.2.0"
 
 "@azure/logger@^1.0.0":
@@ -1296,32 +1296,37 @@ arraybuffer.prototype.slice@^1.0.4:
     get-intrinsic "^1.2.6"
     is-array-buffer "^3.0.4"
 
-"arsenal@git+https://github.com/scality/Arsenal#8.2.18":
-  version "8.2.18"
-  resolved "git+https://github.com/scality/Arsenal#6d0165b870575d77f265bd3dd98b1ca875ebaa06"
+"arsenal@git+https://github.com/scality/Arsenal#8.2.4":
+  version "8.2.4"
+  resolved "git+https://github.com/scality/Arsenal#96ef6a3e26d7528f877300606586759f1da6d0cd"
   dependencies:
-    "@azure/identity" "^4.9.1"
-    "@azure/storage-blob" "^12.27.0"
+    "@azure/identity" "^4.5.0"
+    "@azure/storage-blob" "^12.25.0"
+    "@eslint/plugin-kit" "^0.2.3"
     "@js-sdsl/ordered-set" "^4.4.2"
     "@scality/hdclient" "^1.3.1"
+    "@types/async" "^3.2.24"
+    "@types/utf8" "^3.0.3"
     JSONStream "^1.3.5"
-    agentkeepalive "^4.6.0"
+    agentkeepalive "^4.5.0"
     ajv "6.12.3"
     async "~2.6.4"
     aws-sdk "^2.1691.0"
     backo "^1.1.0"
     base-x "3.0.8"
     base62 "^2.0.2"
+    bson "^6.8.0"
     debug "^4.3.7"
+    diskusage "^1.2.0"
     fcntl "github:scality/node-fcntl#0.3.0"
     httpagent scality/httpagent#1.1.0
-    https-proxy-agent "^7.0.6"
-    ioredis "^5.6.1"
+    https-proxy-agent "^7.0.5"
+    ioredis "^5.4.1"
     ipaddr.js "^2.2.0"
     joi "^17.13.3"
     level "~5.0.1"
     level-sublevel "~6.6.5"
-    mongodb "^6.16.0"
+    mongodb "^6.11.0"
     node-forge "^1.3.1"
     prom-client "^15.1.3"
     simple-glob "^0.2.0"
@@ -1335,9 +1340,9 @@ arraybuffer.prototype.slice@^1.0.4:
   optionalDependencies:
     ioctl "^2.0.2"
 
-"arsenal@git+https://github.com/scality/Arsenal#8.2.4":
-  version "8.2.4"
-  resolved "git+https://github.com/scality/Arsenal#96ef6a3e26d7528f877300606586759f1da6d0cd"
+"arsenal@git+https://github.com/scality/Arsenal#8.2.6":
+  version "8.2.6"
+  resolved "git+https://github.com/scality/Arsenal#ae9f1ec9e93da10c20c22e7197cd92dcc082ba08"
   dependencies:
     "@azure/identity" "^4.5.0"
     "@azure/storage-blob" "^12.25.0"
@@ -1379,37 +1384,32 @@ arraybuffer.prototype.slice@^1.0.4:
   optionalDependencies:
     ioctl "^2.0.2"
 
-"arsenal@git+https://github.com/scality/Arsenal#8.2.6":
-  version "8.2.6"
-  resolved "git+https://github.com/scality/Arsenal#ae9f1ec9e93da10c20c22e7197cd92dcc082ba08"
+"arsenal@git+https://github.com/scality/Arsenal#c102852d95d5ac91fd726d9f37a4faaf65ed6443":
+  version "8.2.19"
+  resolved "git+https://github.com/scality/Arsenal#c102852d95d5ac91fd726d9f37a4faaf65ed6443"
   dependencies:
-    "@azure/identity" "^4.5.0"
-    "@azure/storage-blob" "^12.25.0"
-    "@eslint/plugin-kit" "^0.2.3"
+    "@azure/identity" "^4.10.0"
+    "@azure/storage-blob" "^12.27.0"
     "@js-sdsl/ordered-set" "^4.4.2"
     "@scality/hdclient" "^1.3.1"
-    "@types/async" "^3.2.24"
-    "@types/utf8" "^3.0.3"
     JSONStream "^1.3.5"
-    agentkeepalive "^4.5.0"
+    agentkeepalive "^4.6.0"
     ajv "6.12.3"
     async "~2.6.4"
     aws-sdk "^2.1691.0"
     backo "^1.1.0"
     base-x "3.0.8"
     base62 "^2.0.2"
-    bson "^6.8.0"
-    debug "^4.3.7"
-    diskusage "^1.2.0"
+    debug "^4.4.1"
     fcntl "github:scality/node-fcntl#0.3.0"
     httpagent scality/httpagent#1.1.0
-    https-proxy-agent "^7.0.5"
-    ioredis "^5.4.1"
+    https-proxy-agent "^7.0.6"
+    ioredis "^5.6.1"
     ipaddr.js "^2.2.0"
     joi "^17.13.3"
     level "~5.0.1"
     level-sublevel "~6.6.5"
-    mongodb "^6.11.0"
+    mongodb "^6.16.0"
     node-forge "^1.3.1"
     prom-client "^15.1.3"
     simple-glob "^0.2.0"
@@ -2110,6 +2110,13 @@ debug@^3.1.0, debug@^3.2.7:
   dependencies:
     ms "^2.1.1"
 
+debug@^4.4.1:
+  version "4.4.1"
+  resolved "https://registry.yarnpkg.com/debug/-/debug-4.4.1.tgz#e5a8bc6cbc4c6cd3e64308b0693a3d4fa550189b"
+  integrity sha512-KcKCqiftBJcZr++7ykoDIEwSa3XWowTfNPo92BYxjXiyYEVrUQh2aLyhxBCwww+heortUFxEJYcRzosstTEBYQ==
+  dependencies:
+    ms "^2.1.3"
+
 debug@~4.3.1, debug@~4.3.2, debug@~4.3.4:
   version "4.3.7"
   resolved "https://registry.yarnpkg.com/debug/-/debug-4.3.7.tgz#87945b4151a011d76d95a198d7111c865c360a52"