CLDSRV-744: add config variable to disable PutObjectRetention checksum check

Author: leif-scality

config.json

@@ -142,5 +142,8 @@
     },
     "kmip": {
         "providerName": "thales"
+    },
+    "integrityChecks": {
+        "objectPutRetention": true
     }
 }

lib/Config.js

@@ -533,6 +533,37 @@ function bucketNotifAssert(bucketNotifConfig) {
     return bucketNotifConfig;
 }
 
+function parseIntegrityChecks(config) {
+    const integrityChecks = {
+        'bucketPutACL': true,
+        'bucketPutCors': true,
+        'bucketPutEncryption': true,
+        'bucketPutLifecycle': true,
+        'bucketPutNotification': true,
+        'bucketPutObjectLock': true,
+        'bucketPutPolicy': true,
+        'bucketPutReplication': true,
+        'bucketPutVersioning': true,
+        'bucketPutWebsite': true,
+        'multiObjectDelete': true,
+        'objectPutACL': true,
+        'objectPutLegalHold': true,
+        'objectPutTagging': true,
+        'objectPutRetention': true,
+    };
+
+    if (config && config.integrityChecks) {
+        for (const method in integrityChecks) {
+            if (method in config.integrityChecks) {
+                assert(typeof config.integrityChecks[method] == 'boolean', `bad config: ${method} not boolean`);
+                integrityChecks[method] = config.integrityChecks[method];
+            }
+        }
+    }
+
+    return integrityChecks;
+}
+
 /**
  * Reads from a config file and returns the content as a config object
  */
@@ -1743,6 +1774,8 @@ class Config extends EventEmitter {
 
         this.supportedLifecycleRules = parseSupportedLifecycleRules(config.supportedLifecycleRules);
 
+        this.integrityChecks = parseIntegrityChecks(config);
+
         /**
          * S3C-10336: PutObject max size of 5GB is new in 9.5.1
          * Provides a way to bypass the new validation if it breaks customer workflows
@@ -2081,4 +2114,5 @@ module.exports = {
     azureGetStorageAccountName,
     azureGetLocationCredentials,
     parseSupportedLifecycleRules,
+    parseIntegrityChecks,
 };

tests/unit/Config.js

@@ -7,6 +7,7 @@ const {
     azureGetLocationCredentials,
     locationConstraintAssert,
     parseSupportedLifecycleRules,
+    parseIntegrityChecks,
     ConfigObject,
 } = require('../../lib/Config');
 
@@ -885,4 +886,40 @@ describe('Config', () => {
             assert.strictEqual(config.instanceId.length, 6);
         });
     });
+
+    describe('parse integrity checks', () => {
+        it('should replace default values with new values', () => {
+            const newConfig = {
+                integrityChecks: {
+                    'bucketPutACL': false,
+                    'bucketPutCors': false,
+                    'bucketPutEncryption': false,
+                    'bucketPutLifecycle': false,
+                    'bucketPutNotification': false,
+                    'bucketPutObjectLock': false,
+                    'bucketPutPolicy': false,
+                    'bucketPutReplication': false,
+                    'bucketPutVersioning': false,
+                    'bucketPutWebsite': false,
+                    'multiObjectDelete': false,
+                    'objectPutACL': false,
+                    'objectPutLegalHold': false,
+                    'objectPutTagging': false,
+                    'objectPutRetention': false,
+                },
+            };
+
+            const result = parseIntegrityChecks(newConfig);
+            for (const method in result) {
+                assert(result[method] == false, method);
+            }
+        });
+
+        it('default method value is true', () => {
+            const result = parseIntegrityChecks(null);
+            for (const method in result) {
+                assert(result[method] == true, method);
+            }
+        });
+    });
 });