CLDSRV-720: Add back file test null compat matrix

- Skip Restore tests for file v1

cf: CLDSRV-721

Author: BourgoisMickael

.github/workflows/tests.yaml

@@ -395,7 +395,10 @@ jobs:
     strategy:
       matrix:
         include:
-          - job-name: file-ft-tests
+          - enable-null-compat: ''
+            job-name: file-ft-tests
+          - enable-null-compat: 'true'
+            job-name: file-ft-tests-null-compat
     name: ${{ matrix.job-name }}
     runs-on: ubuntu-24.04
     needs: build
@@ -405,6 +408,7 @@ jobs:
       CLOUDSERVER_IMAGE: ghcr.io/${{ github.repository }}:${{ github.sha }}
       MONGODB_IMAGE: ghcr.io/${{ github.repository }}/ci-mongodb:${{ github.sha }}
       MPU_TESTING: "yes"
+      ENABLE_NULL_VERSION_COMPAT_MODE: "${{ matrix.enable-null-compat }}"
       JOB_NAME: ${{ matrix.job-name }}
     steps:
     - name: Checkout

tests/functional/aws-node-sdk/test/object/mpuVersion.js

@@ -6,7 +6,7 @@ const BucketUtility = require('../../lib/utility/bucket-util');
 const metadata = require('../../../../../lib/metadata/wrapper');
 const { DummyRequestLogger } = require('../../../../unit/helpers');
 const checkError = require('../../lib/utility/checkError');
-const { getMetadata, fakeMetadataArchive } = require('../utils/init');
+const { getMetadata, fakeMetadataArchive, isNullKeyMetadataV1 } = require('../utils/init');
 
 const log = new DummyRequestLogger();
 
@@ -96,7 +96,11 @@ function checkObjMdAndUpdate(objMDBefore, objMDAfter, props) {
     });
 }
 
-describe('MPU with x-scal-s3-version-id header', () => {
+// TODO: CLDSRV-721 RING 10 Support ObjectRestore (cold storage) with MD v1
+// The whole test suite is skipped as bad versionId breaks after each bucket cleanup
+const describeSkipNullMdV1 = isNullKeyMetadataV1 ? describe.skip : describe;
+
+describeSkipNullMdV1('MPU with x-scal-s3-version-id header', () => {
     withV4(sigCfg => {
         let bucketUtil;
         let s3;

tests/functional/aws-node-sdk/test/object/putVersion.js

@@ -6,7 +6,7 @@ const BucketUtility = require('../../lib/utility/bucket-util');
 const metadata = require('../../../../../lib/metadata/wrapper');
 const { DummyRequestLogger } = require('../../../../unit/helpers');
 const checkError = require('../../lib/utility/checkError');
-const { getMetadata, fakeMetadataArchive } = require('../utils/init');
+const { getMetadata, fakeMetadataArchive, isNullKeyMetadataV1 } = require('../utils/init');
 
 const log = new DummyRequestLogger();
 
@@ -47,7 +47,11 @@ function checkObjMdAndUpdate(objMDBefore, objMDAfter, props) {
     });
 }
 
-describe('PUT object with x-scal-s3-version-id header', () => {
+// TODO: CLDSRV-721 RING 10 Support ObjectRestore (cold storage) with MD v1
+// The whole test suite is skipped as bad versionId breaks after each bucket cleanup
+const describeSkipNullMdV1 = isNullKeyMetadataV1 ? describe.skip : describe;
+
+describeSkipNullMdV1('PUT object with x-scal-s3-version-id header', () => {
     withV4(sigCfg => {
         let bucketUtil;
         let s3;

tests/functional/aws-node-sdk/test/utils/init.js

@@ -7,6 +7,19 @@ const log = new DummyRequestLogger();
 const nonVersionedObjId =
     versionIdUtils.getInfVid(config.replicationGroupId);
 
+const isMetadataOrFile = ['file', 'scality'].includes(config.backends.metadata);
+/**
+ * With null version compat mode the null key should look like
+ * 'object1putversion\u000099999999999999999999RG001  '
+ * Without it for BucketFile backends it looks like
+ * 'object1putversion\x00'
+ *
+ * The later case does not support ObjectRestore and needs some tests to be skipped.
+ *
+ * TODO: CLDSRV-721 RING 10 Support ObjectRestore (cold storage) with MD v1
+ */
+const isNullKeyMetadataV1 = isMetadataOrFile && !config.nullVersionCompatMode;
+
 function decodeVersionId(versionId) {
     let decodedVersionId;
     if (versionId) {
@@ -87,6 +100,7 @@ function fakeMetadataArchive(bucketName, objectName, versionId, archive, cb) {
 }
 
 module.exports = {
+    isNullKeyMetadataV1,
 	initMetadata,
 	getMetadata,
 	fakeMetadataArchive,