✨ retrieve the master object to copy it when needed only

Issue: CLDSRV-632

Author: DarkIsDude

lib/api/apiUtils/object/versioning.js

@@ -103,6 +103,7 @@ function _storeNullVersionMD(bucketName, objKey, nullVersionId, objMD, log, cb)
             log.debug('error from metadata storing null version as new version',
             { error: err });
         }
+        
         cb(err);
     });
 }
@@ -265,6 +266,7 @@ function processVersioningState(mst, vstat, nullVersionCompatMode) {
         }
         return { options, nullVersionId };
     }
+
     // backward-compat: keep a reference to the existing null
     // versioned key
     if (mst.nullVersionId) {
@@ -295,6 +297,7 @@ function getMasterState(objMD) {
     if (!objMD) {
         return {};
     }
+
     const mst = {
         exists: true,
         versionId: objMD.versionId,
@@ -304,10 +307,12 @@ function getMasterState(objMD) {
         nullVersionId: objMD.nullVersionId,
         nullUploadId: objMD.nullUploadId,
     };
+
     if (objMD.location) {
         mst.objLocation = Array.isArray(objMD.location) ?
             objMD.location : [objMD.location];
     }
+
     return mst;
 }
 /** versioningPreprocessing - return versioning information for S3 to handle

lib/routes/routeBackbeat.js

@@ -42,6 +42,10 @@ const quotaUtils = require('../api/apiUtils/quotas/quotaUtils');
 const { handleAuthorizationResults } = require('../api/api');
 const { versioningPreprocessing }
     = require('../api/apiUtils/object/versioning');
+const {promisify} = require('util');
+
+const versioningPreprocessingPromised = promisify(versioningPreprocessing);
+metadata.getBucketAndObjectMDPromised = promisify(metadata.getBucketAndObjectMD);
 
 const { CURRENT_TYPE, NON_CURRENT_TYPE, ORPHAN_DM_TYPE } = constants.lifecycleListing;
 
@@ -612,6 +616,7 @@ function putMetadata(request, response, bucketInfo, objMd, log, callback) {
         // To prevent this, the versionId field is only included in options when it is defined.
         if (versionId !== undefined) {
             options.versionId = versionId;
+
             // In the MongoDB metadata backend, setting the versionId option leads to the creation
             // or update of the version object, the master object is only updated if its versionId
             // is the same as the version. This can lead to inconsistencies when replicating objects
@@ -642,6 +647,7 @@ function putMetadata(request, response, bucketInfo, objMd, log, callback) {
                 if (!request.query?.accountId) {
                     return next();
                 }
+
                 return getCanonicalIdsByAccountId(request.query.accountId, log, (err, res) => {
                     if (err) {
                         return next(err);
@@ -651,12 +657,13 @@ function putMetadata(request, response, bucketInfo, objMd, log, callback) {
                     return next();
                 });
             },
-            next => {
-                if (!versionId) {
-                    return next();
+            async () => {
+                if (versioning && !objMd) {
+                    const masterObjectAndBucket =
+                        await metadata.getBucketAndObjectMDPromised(bucketName, objectKey, {}, log);
+                    const masterObject = JSON.parse(masterObjectAndBucket.obj);
+                    await versioningPreprocessingPromised(bucketName, bucketInfo, objectKey, masterObject, log);
                 }
-
-                return versioningPreprocessing(bucketName, bucketInfo, objectKey, objMd, log, next);
             },
             next => {
                 log.trace('putting object version', {

tests/multipleBackend/routes/routeBackbeatForReplication.js

@@ -958,6 +958,7 @@ describe(`backbeat routes for replication (${name})`, () => {
                 if (err) {
                     return next(err);
                 }
+
                 versionId = data.VersionId;
                 return next();
             }),
@@ -974,6 +975,7 @@ describe(`backbeat routes for replication (${name})`, () => {
                 if (err) {
                     return next(err);
                 }
+
                 objMD = objectMDWithUpdatedAccountInfo(data, src === dst ? null : dstAccountInfo);
                 return next();
             }),