CLDSRV-863: handle NoSuchKey error in isCompleteMPUInProgress

Author: leif-scality

lib/services.js

@@ -682,6 +682,16 @@ const services = {
         return metadata.getObjectMD(mpuBucketName, mpuOverviewKey, {}, log,
             (err, res) => {
                 if (err) {
+                    if (err.is && err.is.NoSuchKey) {
+                        // The overview key no longer exists, meaning completeMultipartUpload
+                        // already ran to completion and cleaned up the MPU bucket.
+                        // This is a race condition: objectPutPart checked for old
+                        // part locations after completeMultipartUpload deleted the overview.
+                        // Returning true (complete in progress) prevents objectPutPart
+                        // from deleting part data that may have already been committed
+                        // as the final object.
+                        return cb(null, true);
+                    }
                     log.error('error getting the overview object from mpu bucket', {
                         error: err,
                         method: 'services.isCompleteMPUInProgress',
@@ -737,7 +747,7 @@ const services = {
             metadata.getObjectMD(mpuBucket.getName(), mpuOverviewKey,
                 {}, log, (err, storedMetadata) => {
                     if (err) {
-                        if (err.is.NoSuchKey) {
+                        if (err.is && err.is.NoSuchKey) {
                             return cb(errors.NoSuchUpload);
                         }
                         log.error('error from metadata', { error: err });