CLDSRV-717: Test lifecycle Transition condition

For S3C Integration that don't support Transition

Author: BourgoisMickael

tests/functional/aws-node-sdk/test/bucket/putBucketLifecycle.js

@@ -4,6 +4,7 @@ const { S3 } = require('aws-sdk');
 
 const getConfig = require('../support/config');
 const BucketUtility = require('../../lib/utility/bucket-util');
+const { config } = require('../../../../../lib/Config');
 
 const MAX_DAYS = 2147483647; // Max 32-bit signed binary integer.
 
@@ -483,7 +484,10 @@ describe('aws-sdk test put bucket lifecycle', () => {
             });
         });
 
-        describe('with Transitions', () => {
+        // use env S3_CONFIG_FILE with tests (needed in S3C Integration tests)
+        const isTransitionSupported = config.supportedLifecycleRules.includes('Transition');
+        describe(`with Transitions ${isTransitionSupported ? '' : 'NOT '}supported`, () => {
+
             // Get lifecycle request params with Transitions.
             function getParams(transitions) {
                 const rule = {
@@ -498,14 +502,18 @@ describe('aws-sdk test put bucket lifecycle', () => {
                 };
             }
 
-            it('should allow Days', done => {
+            it(`should ${isTransitionSupported ? '' : 'NOT '}allow Days`, done => {
                 const transitions = [{
                     Days: 0,
                     StorageClass: 'us-east-2',
                 }];
                 const params = getParams(transitions);
                 s3.putBucketLifecycleConfiguration(params, err => {
-                    assert.ifError(err);
+                    if (isTransitionSupported) {
+                        assert.ifError(err);
+                    } else {
+                        assert.strictEqual(err && err.code, 'NotImplemented');
+                    }
                     done();
                 });
             });
@@ -517,7 +525,11 @@ describe('aws-sdk test put bucket lifecycle', () => {
                 }];
                 const params = getParams(transitions);
                 s3.putBucketLifecycleConfiguration(params, err => {
-                    assert.strictEqual(err.code, 'MalformedXML');
+                    if (isTransitionSupported) {
+                        assert.strictEqual(err.code, 'MalformedXML');
+                    } else {
+                        assert.strictEqual(err.code, 'NotImplemented');
+                    }
                     done();
                 });
             });
@@ -529,9 +541,13 @@ describe('aws-sdk test put bucket lifecycle', () => {
                 }];
                 const params = getParams(transitions);
                 s3.putBucketLifecycleConfiguration(params, err => {
-                    assert.strictEqual(err.code, 'InvalidArgument');
-                    assert.strictEqual(err.message,
-                        "'Days' in Transition action must be nonnegative");
+                    if (isTransitionSupported) {
+                        assert.strictEqual(err.code, 'InvalidArgument');
+                        assert.strictEqual(err.message,
+                            "'Days' in Transition action must be nonnegative");
+                    } else {
+                        assert.strictEqual(err.code, 'NotImplemented');
+                    }
                     done();
                 });
             });
@@ -546,23 +562,31 @@ describe('aws-sdk test put bucket lifecycle', () => {
                 }];
                 const params = getParams(transitions);
                 s3.putBucketLifecycleConfiguration(params, err => {
-                    assert.strictEqual(err.code, 'InvalidRequest');
-                    assert.strictEqual(err.message,
-                        "'StorageClass' must be different for 'Transition' " +
-                        "actions in same 'Rule' with prefix ''");
+                    if (isTransitionSupported) {
+                        assert.strictEqual(err.code, 'InvalidRequest');
+                        assert.strictEqual(err.message,
+                            "'StorageClass' must be different for 'Transition' " +
+                            "actions in same 'Rule' with prefix ''");
+                    } else {
+                        assert.strictEqual(err.code, 'NotImplemented');
+                    }
                     done();
                 });
             });
 
             // TODO: Upgrade to aws-sdk >= 2.60.0 for correct Date field support
-            it.skip('should allow Date', done => {
+            it.skip(`should ${isTransitionSupported ? '' : 'NOT '}allow Date`, done => {
                 const transitions = [{
                     Date: '2016-01-01T00:00:00.000Z',
                     StorageClass: 'us-east-2',
                 }];
                 const params = getParams(transitions);
                 s3.putBucketLifecycleConfiguration(params, err => {
-                    assert.ifError(err);
+                    if (isTransitionSupported) {
+                        assert.ifError(err);
+                    } else {
+                        assert.strictEqual(err.code, 'NotImplemented');
+                    }
                     done();
                 });
             });
@@ -577,7 +601,11 @@ describe('aws-sdk test put bucket lifecycle', () => {
                 }];
                 const params = getParams(transitions);
                 s3.putBucketLifecycleConfiguration(params, err => {
-                    assert.strictEqual(err.code, 'MalformedXML');
+                    if (isTransitionSupported) {
+                        assert.strictEqual(err.code, 'MalformedXML');
+                    } else {
+                        assert.strictEqual(err.code, 'NotImplemented');
+                    }
                     done();
                 });
             });
@@ -594,10 +622,14 @@ describe('aws-sdk test put bucket lifecycle', () => {
                 }];
                 const params = getParams(transitions);
                 s3.putBucketLifecycleConfiguration(params, err => {
-                    assert.strictEqual(err.code, 'InvalidRequest');
-                    assert.strictEqual(err.message,
-                        "Found mixed 'Date' and 'Days' based Transition " +
-                        "actions in lifecycle rule for prefix ''");
+                    if (isTransitionSupported) {
+                        assert.strictEqual(err.code, 'InvalidRequest');
+                        assert.strictEqual(err.message,
+                            "Found mixed 'Date' and 'Days' based Transition " +
+                            "actions in lifecycle rule for prefix ''");
+                    } else {
+                        assert.strictEqual(err.code, 'NotImplemented');
+                    }
                     done();
                 });
             });
@@ -612,10 +644,14 @@ describe('aws-sdk test put bucket lifecycle', () => {
                 const params = getParams(transitions);
                 params.LifecycleConfiguration.Rules[0].Expiration = { Date: 0 };
                 s3.putBucketLifecycleConfiguration(params, err => {
-                    assert.strictEqual(err.code, 'InvalidRequest');
-                    assert.strictEqual(err.message,
-                        "Found mixed 'Date' and 'Days' based Expiration and " +
-                        "Transition actions in lifecycle rule for prefix ''");
+                    if (isTransitionSupported) {
+                        assert.strictEqual(err.code, 'InvalidRequest');
+                        assert.strictEqual(err.message,
+                            "Found mixed 'Date' and 'Days' based Expiration and " +
+                            "Transition actions in lifecycle rule for prefix ''");
+                    } else {
+                        assert.strictEqual(err.code, 'NotImplemented');
+                    }
                     done();
                 });
             });