CLDSRV-909: Honor bypassMaxPutObjectSize flag on CopyObject size limit

Author: tcarmet

lib/api/objectCopy.js

@@ -352,7 +352,7 @@ function objectCopy(authInfo, request, sourceBucket,
                         return next(err, destBucketMD);
                     }
                     const sourceSize = parseInt(sourceObjMD['content-length'], 10);
-                    if (sourceSize > constants.maximumAllowedUploadSize) {
+                    if (sourceSize > constants.maximumAllowedUploadSize && !config.bypassMaxPutObjectSize) {
                         log.debug('copy source object too large', { sourceSize });
                         const err = errorInstances.InvalidRequest.customizeDescription(
                             'The specified copy source is larger than the maximum ' +

tests/unit/api/objectCopy.js

@@ -659,6 +659,7 @@ describe('objectCopy source size limit', () => {
 
     after(() => {
         constants.maximumAllowedUploadSize = originalMaximumUploadSize;
+        config.bypassMaxPutObjectSize = false;
         cleanup();
     });
 
@@ -684,4 +685,15 @@ describe('objectCopy source size limit', () => {
                 done();
             });
     });
+
+    it('should allow CopyObject when source size exceeds the limit but bypass flag is set', done => {
+        constants.maximumAllowedUploadSize = sourceSize - 1;
+        config.bypassMaxPutObjectSize = true;
+        const testObjectCopyRequest = _createObjectCopyRequest(destBucketName);
+        objectCopy(authInfo, testObjectCopyRequest, sourceBucketName, objectKey,
+            undefined, log, err => {
+                assert.ifError(err);
+                done();
+            });
+    });
 });