♻️ prefer promisify over manual new Promise

Issue: CLDSRV-878

Author: DarkIsDude

lib/routes/veeam/list.js

@@ -6,7 +6,9 @@ const metadata = require('../../metadata/wrapper');
 const { responseXMLBody } = require('arsenal/build/lib/s3routes/routesUtils');
 const { respondWithData, getResponseHeader, buildHeadXML, validPath, fetchCapacityMetrics } = require('./utils');
 const { processVersions, processMasterVersions } = require('../../api/bucketGet');
+const { promisify } = require('util');
 
+metadata.getBucketPromised = promisify(metadata.getBucket);
 
 /**
  * Utility function to build a standard response for the LIST route.
@@ -96,12 +98,7 @@ async function listVeeamFiles(request, response, bucketMd, log) {
 
     let data;
     try {
-        data = await new Promise((resolve, reject) =>
-            metadata.getBucket(request.bucketName, log, (err, result) => {
-                if (err) { return reject(err); }
-                return resolve(result);
-            })
-        );
+        data = await metadata.getBucket(request.bucketName, log);
     } catch {
         return responseXMLBody(errors.InternalError, null, response, log);
     }

lib/routes/veeam/utils.js

@@ -10,6 +10,8 @@ const UtilizationService = require('../../utilization/instance');
 const metadata = require('../../metadata/wrapper');
 
 const pipeline = promisify(streamPipeline);
+const getUtilizationMetrics = promisify(UtilizationService.getUtilizationMetrics.bind(UtilizationService));
+metadata.getBucketPromised = promisify(metadata.getBucket);
 
 /**
  * Decodes an URI and return the result.
@@ -217,12 +219,7 @@ function getFileToBuild(request, data, inlineLastModified = false) {
 async function fetchCapacityMetrics(bucketMd, request, log, method) {
     const bucketKey = `${bucketMd._name}_${new Date(bucketMd._creationDate).getTime()}`;
     try {
-        return await new Promise((resolve, reject) =>
-            UtilizationService.getUtilizationMetrics('bucket', bucketKey, null, {}, (err, bucketMetrics) => {
-                if (err) { return reject(err); }
-                return resolve(bucketMetrics);
-            })
-        );
+        return await getUtilizationMetrics('bucket', bucketKey, null, {});
     } catch (err) {
         const statusCode = err.response?.status || err.statusCode || err.code;
         if (statusCode === 404) {
@@ -255,12 +252,7 @@ async function fetchCapacityMetrics(bucketMd, request, log, method) {
 async function buildVeeamFileData(request, bucketMd, log, name) {
     let data;
     try {
-        data = await new Promise((resolve, reject) =>
-            metadata.getBucket(request.bucketName, log, (err, result) => {
-                if (err) { return reject(err); }
-                return resolve(result);
-            })
-        );
+        data = await metadata.getBucketPromised(request.bucketName, log);
     } catch {
         throw errors.InternalError;
     }