test many chunk split

Author: fredmnl

tests/functional/raw-node/test/trailingChecksums.js

@@ -6,6 +6,7 @@ const HttpRequestAuthV4 = require('../utils/HttpRequestAuthV4');
 const bucket = 'testunsupportedchecksumsbucket';
 const objectKey = 'key';
 const objData = Buffer.alloc(1024, 'a');
+// note this is not the correct checksum in objDataWithTrailingChecksum
 const objDataWithTrailingChecksum = '10\r\n0123456789abcdef\r\n0\r\nx-amz-checksum-crc64nvme:YeIDuLa7tU0=\r\n';
 const objDataWithoutTrailingChecksum = '0123456789abcdef';
 
@@ -47,51 +48,69 @@ describe('trailing checksum requests:', () => {
         });
     });
 
-    it('should accept unsigned trailing checksum', done => {
-        const req = new HttpRequestAuthV4(
-            `http://localhost:8000/${bucket}/${objectKey}`,
-            Object.assign(
-                {
-                    method: 'PUT',
-                    headers: {
-                        'content-length': objDataWithTrailingChecksum.length,
-                        'x-amz-decoded-content-length': objDataWithoutTrailingChecksum.length,
-                        'x-amz-content-sha256': 'STREAMING-UNSIGNED-PAYLOAD-TRAILER',
-                        'x-amz-trailer': 'x-amz-checksum-crc64nvme',
+    const objDataChunkings = [
+        [objDataWithTrailingChecksum],
+        [objDataWithTrailingChecksum.substring(0, 1), objDataWithTrailingChecksum.substring(1)],
+        [objDataWithTrailingChecksum.substring(0, 2), objDataWithTrailingChecksum.substring(2)],
+        [objDataWithTrailingChecksum.substring(0, 3), objDataWithTrailingChecksum.substring(3)],
+        [objDataWithTrailingChecksum.substring(0, 4), objDataWithTrailingChecksum.substring(4)],
+        [objDataWithTrailingChecksum.substring(0, 10), objDataWithTrailingChecksum.substring(10)],
+        [objDataWithTrailingChecksum.substring(0, 20), objDataWithTrailingChecksum.substring(20)],
+        [objDataWithTrailingChecksum.substring(0, 21), objDataWithTrailingChecksum.substring(21)],
+        [objDataWithTrailingChecksum.substring(0, 22), objDataWithTrailingChecksum.substring(22)],
+    ];
+
+    objDataChunkings.forEach((objDataChunks, index) => {
+        it(`should accept unsigned trailing checksum, chunk configuration ${index + 1}`, done => {
+            const req = new HttpRequestAuthV4(
+                `http://localhost:8000/${bucket}/${objectKey}`,
+                Object.assign(
+                    {
+                        method: 'PUT',
+                        headers: {
+                            'content-length': objDataWithTrailingChecksum.length,
+                            'x-amz-decoded-content-length': objDataWithoutTrailingChecksum.length,
+                            'x-amz-content-sha256': 'STREAMING-UNSIGNED-PAYLOAD-TRAILER',
+                            'x-amz-trailer': 'x-amz-checksum-crc64nvme',
+                        },
                     },
-                },
-                authCredentials
-            ),
-            res => {
-                assert.strictEqual(res.statusCode, 200);
-                res.on('data', () => {});
-                res.on('end', done);
-            }
-        );
+                    authCredentials
+                ),
+                res => {
+                    assert.strictEqual(res.statusCode, 200);
+                    res.on('data', () => {});
+                    res.on('end', done);
+                }
+            );
 
-        req.on('error', err => {
-            assert.ifError(err);
-        });
+            req.on('error', err => {
+                assert.ifError(err);
+            });
 
-        req.write(objDataWithTrailingChecksum);
+            // write the data in two chunks
+            objDataChunks.forEach(chunk => {
+                req.write(chunk);
+            }
+            );
 
-        req.once('drain', () => {
-            req.end();
+            req.once('drain', () => {
+                req.end();
+            });
         });
-    });
 
-    it('should have correct object content for unsigned trailing checksum', done => {
-        makeS3Request({
-            method: 'GET',
-            authCredentials,
-            bucket,
-            objectKey,
-        }, (err, res) => {
-            assert.ifError(err);
-            assert.strictEqual(res.statusCode, 200);
-            // check that the object data is the input stripped of the trailing checksum
-            assert.strictEqual(res.body, objDataWithoutTrailingChecksum);
-            return done();
+        it('should have correct object content for unsigned trailing checksum', done => {
+            makeS3Request({
+                method: 'GET',
+                authCredentials,
+                bucket,
+                objectKey,
+            }, (err, res) => {
+                assert.ifError(err);
+                assert.strictEqual(res.statusCode, 200);
+                // check that the object data is the input stripped of the trailing checksum
+                assert.strictEqual(res.body, objDataWithoutTrailingChecksum);
+                return done();
+            });
         });
     });