fixup default metrics

BourgoisMickael · BourgoisMickael · commit 88302497a7c7 · 2025-07-23T11:04:12.000+02:00
diff --git a/lib/server.js b/lib/server.js
@@ -377,7 +377,6 @@ function main() {
         process.env.REPORT_TOKEN = _config.reportToken;
         const server = new S3Server(_config);
         server.initiateStartup(logger.newRequestLogger());
-        monitoringClient.collectDefaultMetrics({ timeout: 5000 });
     }
     if (_config.isCluster && cluster.isPrimary) {
         for (let n = 0; n < workers; n++) {
@@ -428,6 +427,10 @@ function main() {
     if (_config.isCluster && cluster.isWorker) {
         const server = new S3Server(_config, cluster.worker);
         server.initiateStartup(logger.newRequestLogger());
+    }
+
+    // Avoid default metrics on cluster primary as it only aggregate workers
+    if (!_config.isCluster || cluster.isWorker) {
         monitoringClient.collectDefaultMetrics({ timeout: 5000 });
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -377,7 +377,6 @@ function main() {`
`377`	`377`	`process.env.REPORT_TOKEN = _config.reportToken;`
`378`	`378`	`const server = new S3Server(_config);`
`379`	`379`	`server.initiateStartup(logger.newRequestLogger());`
`380`		`- monitoringClient.collectDefaultMetrics({ timeout: 5000 });`
`381`	`380`	`}`
`382`	`381`	`if (_config.isCluster && cluster.isPrimary) {`
`383`	`382`	`for (let n = 0; n < workers; n++) {`
`@@ -428,6 +427,10 @@ function main() {`
`428`	`427`	`if (_config.isCluster && cluster.isWorker) {`
`429`	`428`	`const server = new S3Server(_config, cluster.worker);`
`430`	`429`	`server.initiateStartup(logger.newRequestLogger());`
	`430`	`+ }`
	`431`	`+`
	`432`	`+ // Avoid default metrics on cluster primary as it only aggregate workers`
	`433`	`+ if (!_config.isCluster \|\| cluster.isWorker) {`
`431`	`434`	`monitoringClient.collectDefaultMetrics({ timeout: 5000 });`
`432`	`435`	`}`
`433`	`436`	`}`