CLDSRV-905: remove unused eslint-disable comments

Author: leif-scality

lib/api/apiUtils/object/coldStorage.js

@@ -22,7 +22,6 @@ function getAmzRestoreResHeader(objMD) {
         !objMD.archive.restoreCompletedAt) {
         // Avoid race condition by relying on the `archive` MD of the object
         // and return the right header after a RESTORE request.
-        // eslint-disable-next-line
         return `ongoing-request="true"`;
     }
     if (objMD['x-amz-restore']) {

lib/utilities/serverAccessLogger.js

@@ -207,7 +207,6 @@ function getRemoteIPFromRequest(request) {
     return remoteIP;
 }
 
-// eslint-disable-next-line max-len
 // https://github.com/awslabs/glue-extensions-for-iceberg/blob/52bdb2908216a85859fd76a45981d0326d016a2f/spark/src/main/scala/software/amazon/glue/s3a/audit/S3LogVerbs.java
 // https://github.com/open-io/swift/blob/ff518e9907f74b5a2565973a260f36386b5d5cbf/etc/s3-default.cfg.in#L78
 // https://stackoverflow.com/questions/42707878/amazon-s3-logs-operation-definition

tests/functional/aws-node-sdk/test/bucket/get.js

@@ -893,7 +893,6 @@ describe('GET Bucket - AWS.S3.listObjects', () => {
                         .catch(() => {});
                 });
 
-                // eslint-disable-next-line max-len
                 it('should allow when the bucket policy supplies scality:ListBucketOptionalObjectAttributes that IAM lacks', async () => {
                     await bucketUtil.s3.send(new PutBucketPolicyCommand({
                         Bucket: bucketName,

tests/functional/aws-node-sdk/test/bucket/putBucketPolicy.js

@@ -170,12 +170,12 @@ describe('aws-sdk test put bucket policy', () => {
         });
 
         it('should allow bucket policy with pincipal arn less than 2048 characters', async () => {
-            const params = getPolicyParams({ key: 'Principal', value: { AWS: `arn:aws:iam::767707094035:user/${generateRandomString(150)}` } }); // eslint-disable-line max-len
+            const params = getPolicyParams({ key: 'Principal', value: { AWS: `arn:aws:iam::767707094035:user/${generateRandomString(150)}` } });
             await s3.send(new PutBucketPolicyCommand(params));
         });
 
         it('should not allow bucket policy with pincipal arn more than 2048 characters', async () => {
-            const params = getPolicyParams({ key: 'Principal', value: { AWS: `arn:aws:iam::767707094035:user/${generateRandomString(2020)}` } }); // eslint-disable-line max-len
+            const params = getPolicyParams({ key: 'Principal', value: { AWS: `arn:aws:iam::767707094035:user/${generateRandomString(2020)}` } });
             try {
                 await s3.send(new PutBucketPolicyCommand(params));
                 throw new Error('Expected MalformedPolicy error');

tests/unit/api/apiUtils/permissionChecks.js

@@ -48,7 +48,6 @@ describe('authInfoHelper', () => {
 });
 
 describe('checkBucketPolicy Principal logic', () => {
-    /* eslint-disable max-len */
     const tests = [
         {
             description: 'bucket owner with same canonicalID as requesters should return ALLOW',
@@ -702,7 +701,6 @@ describe('checkBucketPolicy Principal logic', () => {
             expectedResult: checkBucketPolicyResult.ALLOW,
         },
     ];
-    /* eslint-enable max-len */
 
     tests.forEach(t => {
         it(t.description, () => {

tests/unit/api/apiUtils/rateLimit/config.js

@@ -442,7 +442,6 @@ describe('parseRateLimitConfig', () => {
 
             assert.throws(
                 () => parseRateLimitConfig(config),
-                // eslint-disable-next-line max-len
                 /rateLimiting configuration is invalid.*"bucket.defaultConfig.requestsPerSecond.limit" must be larger than or equal to 0/
             );
         });
@@ -520,7 +519,6 @@ describe('parseRateLimitConfig', () => {
 
             assert.throws(
                 () => parseRateLimitConfig(config),
-                // eslint-disable-next-line max-len
                 /rateLimiting configuration is invalid.*"bucket.defaultConfig.requestsPerSecond.burstCapacity" must be a positive number/
             );
         });
@@ -540,7 +538,6 @@ describe('parseRateLimitConfig', () => {
 
             assert.throws(
                 () => parseRateLimitConfig(config),
-                // eslint-disable-next-line max-len
                 /rateLimiting configuration is invalid.*"bucket.defaultConfig.requestsPerSecond.burstCapacity" must be a positive number/
             );
         });
@@ -560,7 +557,6 @@ describe('parseRateLimitConfig', () => {
 
             assert.throws(
                 () => parseRateLimitConfig(config),
-                // eslint-disable-next-line max-len
                 /rateLimiting configuration is invalid.*"bucket.defaultConfig.requestsPerSecond.burstCapacity" must be a number/
             );
         });
@@ -1039,7 +1035,6 @@ describe('parseRateLimitConfig', () => {
 
             assert.throws(
                 () => parseRateLimitConfig(config),
-                // eslint-disable-next-line max-len
                 /rateLimiting configuration is invalid.*"account.defaultConfig.requestsPerSecond.burstCapacity" must be a positive number/
             );
         });
@@ -1059,7 +1054,6 @@ describe('parseRateLimitConfig', () => {
 
             assert.throws(
                 () => parseRateLimitConfig(config),
-                // eslint-disable-next-line max-len
                 /rateLimiting configuration is invalid.*"account.defaultConfig.requestsPerSecond.burstCapacity" must be a positive number/
             );
         });
@@ -1079,7 +1073,6 @@ describe('parseRateLimitConfig', () => {
 
             assert.throws(
                 () => parseRateLimitConfig(config),
-                // eslint-disable-next-line max-len
                 /rateLimiting configuration is invalid.*"account.defaultConfig.requestsPerSecond.burstCapacity" must be a number/
             );
         });