fixup! support crr location in the locationConstaint config list

Author: Kerkesni

lib/Config.js

@@ -385,10 +385,6 @@ function locationConstraintAssert(locationConstraints) {
             assert(locationConstraints[l].isCold === true);
         }
 
-        if (locationConstraints[l].type === 'crr') {
-            assert(locationConstraints[l].isCrr === true);
-        }
-
         if (process.env.CI_CEPH === 'true') {
             // eslint-disable-next-line no-param-reassign
             locationConstraints[l].details.https = false;

locationConfig.json

@@ -113,7 +113,7 @@
         "type": "crr",
         "objectId": "location-crr-v1",
         "legacyAwsBehavior": false,
-        "isCrr": true,
+        "isCRR": true,
         "details": {}
     }
 }

tests/locationConfig/locationConfigCeph.json

@@ -268,7 +268,7 @@
         "type": "crr",
         "objectId": "location-crr-v1",
         "legacyAwsBehavior": false,
-        "isCrr": true,
+        "isCRR": true,
         "details": {}
     }
 }

tests/locationConfig/locationConfigLegacy.json

@@ -190,7 +190,7 @@
         "type": "crr",
         "objectId": "location-crr-v1",
         "legacyAwsBehavior": false,
-        "isCrr": true,
+        "isCRR": true,
         "details": {}
     }
 }

tests/locationConfig/locationConfigTests.json

@@ -279,7 +279,7 @@
         "type": "crr",
         "objectId": "location-crr-v1",
         "legacyAwsBehavior": false,
-        "isCrr": true,
+        "isCRR": true,
         "details": {}
     }
 }

tests/multipleBackend/backendHealthcheckResponse.js

@@ -22,8 +22,8 @@ describe('Healthcheck response', () => {
         clientCheck(true, log, (err, results) => {
             const resultKeys = Object.keys(results);
             locConstraints.forEach(constraint => {
-                if (constraint === 'location-dmf-v1' || constraint === 'location-crr-v1') {
-                    // FIXME: location-dmf-v1 and location-crr-v1 are not in results, see CLDSRV-440
+                if (constraint === 'location-dmf-v1') {
+                    // FIXME: location-dmf-v1 not in results, see CLDSRV-440
                     return;
                 }
                 assert(resultKeys.includes(constraint), `constraint: ${constraint} not in results: ${resultKeys}`);
@@ -45,8 +45,8 @@ describe('Healthcheck response', () => {
         clientCheck(false, log, (err, results) => {
             assert.notStrictEqual(results.length, locConstraints.length);
             locConstraints.forEach(constraint => {
-                if (constraint === 'location-dmf-v1' || constraint === 'location-crr-v1') {
-                    // FIXME: location-dmf-v1 and location-crr-v1 are not in results, see CLDSRV-440
+                if (constraint === 'location-dmf-v1') {
+                    // FIXME: location-dmf-v1 not in results, see CLDSRV-440
                     return;
                 }
                 if (Object.keys(results).indexOf(constraint) === -1) {