Skip to content

Commit a24d60c

Browse files
committed
♻️ use trampoline function to keep backward compatibility
Issue: CLDSRV-823
1 parent 757f7e6 commit a24d60c

File tree

2 files changed

+15
-10
lines changed

2 files changed

+15
-10
lines changed

lib/api/bucketGet.js

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,13 @@ function handleResult(listParams, requestMaxKeys, encoding, authInfo, bucketName
261261
* @param {function} log - Werelogs request logger
262262
* @return {Promise<object>} - object containing xml and additionalResHeaders
263263
*/
264-
async function bucketGet(authInfo, request, log) {
264+
async function bucketGet(authInfo, request, log, callback) {
265+
if (callback) {
266+
return bucketGet(authInfo, request, log)
267+
.then(result => callback(null, ...result))
268+
.catch(err => callback(err, null, err.additionalResHeaders));
269+
}
270+
265271
const params = request.query;
266272
const bucketName = request.bucketName;
267273
const v2 = params['list-type'];
@@ -385,12 +391,5 @@ async function bucketGet(authInfo, request, log) {
385391
module.exports = {
386392
processVersions,
387393
processMasterVersions,
388-
bucketGet: (...args) => {
389-
const callback = args.at(-1);
390-
const argsWithoutCallback = args.slice(0, -1);
391-
392-
bucketGet(...argsWithoutCallback)
393-
.then(result => callback(null, ...result))
394-
.catch(err => callback(err, null, err.additionalResHeaders));
395-
},
394+
bucketGet,
396395
};

lib/api/objectGetLegalHold.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,13 @@ const standardMetadataValidateBucketAndObjPromised = (metadataValParams, actionI
2424
* @param {object} log - Werelogs logger
2525
* @return {Promise<object>} - object containing xml and additionalResHeaders
2626
*/
27-
async function objectGetLegalHold(authInfo, request, log) {
27+
async function objectGetLegalHold(authInfo, request, log, callback) {
28+
if (callback) {
29+
return objectGetLegalHold(authInfo, request, log)
30+
.then(result => callback(null, ...result))
31+
.catch(err => callback(err, null, err.additionalResHeaders));
32+
}
33+
2834
log.debug('processing request', { method: 'objectGetLegalHold' });
2935

3036
const { bucketName, objectKey, query } = request;

0 commit comments

Comments
 (0)