post review fixups

Author: benzekrimaha

tests/functional/aws-node-sdk/lib/utility/tagging.js

@@ -5,9 +5,11 @@ const taggingTests = [
         it: 'should return tags if value is an empty string' },
     { tag: { key: 'w'.repeat(129), value: 'foo' },
         error: 'InvalidTag',
+        code: 400,
         it: 'should return InvalidTag if key length is greater than 128' },
     { tag: { key: 'bar', value: 'f'.repeat(257) },
         error: 'InvalidTag',
+        code: 400,
         it: 'should return InvalidTag if key length is greater than 256',
     },
 ];

tests/functional/aws-node-sdk/lib/utility/versioning-util.js

@@ -31,7 +31,6 @@ function _deleteVersionList(versionList, bucket, callback) {
 function checkOneVersion(s3, bucket, versionId, callback) {
     return s3Client.send(new ListObjectVersionsCommand({ Bucket: bucket })).then(data => {
             assert.strictEqual(data.Versions.length, 1);
-        
             if (versionId) {
                 assert.strictEqual(data.Versions[0].VersionId, versionId);
             }

tests/functional/aws-node-sdk/test/object/abortMPU.js

@@ -39,7 +39,7 @@ async function cleanupVersionedBucket(bucketUtil, bucketName) {
     const listMPUResponse = await bucketUtil.s3.send(new ListMultipartUploadsCommand({ Bucket: bucketName }));
     if (listMPUResponse.Uploads && listMPUResponse.Uploads.length > 0) {
         await Promise.all(listMPUResponse.Uploads.map(async upload => {
-                await bucketUtil.s3.send(new AbortMultipartUploadCommand({
+                bucketUtil.s3.send(new AbortMultipartUploadCommand({
                     Bucket: bucketName,
                     Key: upload.Key,
                     UploadId: upload.UploadId,
@@ -501,7 +501,7 @@ describe('Abort MPU - Versioned Bucket Cleanup', function testSuite() {
                 next => {
                     s3.send(new ListObjectVersionsCommand({ Bucket: bucketName }))
                         .then(data => {
-                            const objectVersions = data.Versions?.filter(v => v.Key === objectKey) || [];
+                            const objectVersions = (data.Versions || []).filter(v => v.Key === objectKey);
                             assert.strictEqual(objectVersions.length, 0,
                                 `Expected 0 versions after abort, got ${objectVersions.length}`);
                             next();
@@ -648,6 +648,7 @@ describe('Abort MPU - Orphan Cleanup', function testSuite() {
                 assert.fail('Orphaned object should be deleted after abort');
             } catch (err) {
                 assert(err);
+                assert.strictEqual(err.name, 'NotFound');
                 assert.strictEqual(err.$metadata.httpStatusCode, 404);
             }
         });
@@ -812,7 +813,7 @@ describe('Abort MPU - Race Conditions', function testSuite() {
 
             // Verify no MPU metadata remains
             const listResult = await s3.send(new ListMultipartUploadsCommand({ Bucket: bucketName }));
-            const remainingUploads = listResult.Uploads?.filter(upload => upload.UploadId === uploadId) || [];
+            const remainingUploads = (listResult.Uploads || [] ).filter(upload => upload.UploadId === uploadId);
             assert.strictEqual(remainingUploads.length, 0, 'No MPU metadata should remain');
         });
 
@@ -881,7 +882,7 @@ describe('Abort MPU - Race Conditions', function testSuite() {
 
             // Verify no MPU metadata remains
             const listResult = await s3.send(new ListMultipartUploadsCommand({ Bucket: bucketName }));
-            const remainingUploads = listResult.Uploads?.filter(upload => upload.UploadId === uploadId) || [];
+            const remainingUploads = (listResult.Uploads || []).filter(upload => upload.UploadId === uploadId);
             assert.strictEqual(remainingUploads.length, 0,
                 'No MPU metadata should remain after concurrent aborts');
         });

tests/functional/aws-node-sdk/test/object/bigMpu.js

@@ -53,7 +53,7 @@ function uploadPart(n, uploadId, s3, next) {
 // could be poor system resources.
 describe('large mpu', function tester() {
     this.timeout(600000);
-    let s3;    
+    let s3;
     before(done => {
         const config = getConfig('default', { signatureVersion: 'v4' });
         // disable node sdk retries and timeout to prevent InvalidPart
@@ -94,7 +94,6 @@ describe('large mpu', function tester() {
     itSkipIfAWS('should intiate, put parts and complete mpu ' +
         `with ${partCount} parts`, done => {
         process.stdout.write('***Running large MPU test***\n');
-        const startTime = Date.now(); // Record start time for performance measurement
         let uploadId;     
         return waterfall([
             next => {
@@ -126,7 +125,7 @@ describe('large mpu', function tester() {
                         ETag: partETags[i],
                         PartNumber: i + 1,
                     });
-                }     
+                }
                 const params = {
                     Bucket: bucket,
                     Key: key,
@@ -137,8 +136,7 @@ describe('large mpu', function tester() {
                 };
                 return s3.send(new CompleteMultipartUploadCommand(params))
                     .then(() => {
-                        const duration = Date.now() - startTime;
-                        process.stdout.write(`mpu completed successfully in ${duration}ms\n`);
+                        process.stdout.write(`mpu completed successfully\n`);
                         next();
                     })
                     .catch(err => next(err));

tests/functional/aws-node-sdk/test/object/completeMPU.js

@@ -41,7 +41,7 @@ describe('Complete MPU', () => {
                 UploadId: uploadId 
             }))
             .then(data => {
-                versionId = data.VersionId; // Assign to the outer scope variable
+                versionId = data.VersionId;
                 if (expectedVid) {
                     assert.notEqual(versionId, undefined);
                 } else {
@@ -54,12 +54,11 @@ describe('Complete MPU', () => {
             })
             .then(data => {
                 if (versionId) {
-                    // Check version ID when we expect one
                     assert.strictEqual(data.VersionId, versionId);
                 }
                 cb();
             })
-            .catch(err => cb(err));
+            .catch(cb);
         }
 
         function _initiateMpuAndPutOnePart() {
@@ -156,7 +155,6 @@ describe('Complete MPU', () => {
                 .then(result => {
                     uploadId = result.uploadId;
                     eTag = result.eTag;
-                    return result;
                 })
             );
 
@@ -246,7 +244,8 @@ describe('Complete MPU', () => {
                 });
             });
         });
-         describe('with re-upload of part during CompleteMPU execution', () => {
+
+        describe('with re-upload of part during CompleteMPU execution', () => {
             let uploadId;
             let eTag;