fixup test move destroyKmsKey promisify into helpers file

Author: BourgoisMickael

tests/functional/sse-kms-migration/arnPrefix.js

@@ -6,7 +6,6 @@ const log = new DummyRequestLogger();
 const { makeRequest } = require('../raw-node/utils/makeRequest');
 const helpers = require('./helpers');
 const scenarios = require('./scenarios');
-const kms = require('../../../lib/kms/wrapper');
 
 // copy part of aws-node-sdk/test/object/encryptionHeaders.js and add more tests
 
@@ -508,7 +507,6 @@ describe('ensure MPU use good SSE', () => {
 });
 
 describe('KMS error', () => {
-    const destroyKmsKey = promisify(kms.destroyBucketKey);
     const sseConfig = { algo: 'aws:kms', masterKeyId: true }
     const Bucket = 'bkt-kms-err';
     const Key = 'obj';
@@ -560,14 +558,14 @@ describe('KMS error', () => {
         // ensure we can decrypt and read the object
         const obj = await helpers.s3.getObject({ Bucket, Key }).promise();
         assert.strictEqual(obj.Body.toString(), body);
-        void await destroyKmsKey(masterKeyArn, log);
+        void await helpers.destroyKmsKey(masterKeyArn, log);
     });
 
     after(async () => {
         void await helpers.cleanup(Bucket);
         if (masterKeyArn) {
             try {
-                void await destroyKmsKey(masterKeyArn, log);
+                void await helpers.destroyKmsKey(masterKeyArn, log);
             } catch (e) { void e; }
             [masterKeyArn, masterKeyId] = [null, null];
         }
@@ -576,7 +574,7 @@ describe('KMS error', () => {
     afterEach(async () => {
         if (anotherKeyInfo) {
             try {
-                void await destroyKmsKey(anotherKeyInfo.masterKeyArn, log);
+                void await helpers.destroyKmsKey(anotherKeyInfo.masterKeyArn, log);
             } catch (e) { void e; }
             anotherKeyInfo = null;
         }
@@ -642,7 +640,7 @@ describe('KMS error', () => {
         const mpu = await helpers.s3.createMultipartUpload(
             helpers.putObjParams(Bucket, mpuKey, sseConfig, anotherKeyInfo.masterKeyArn)).promise();
 
-        void await destroyKmsKey(anotherKeyInfo.masterKeyArn, log);
+        void await helpers.destroyKmsKey(anotherKeyInfo.masterKeyArn, log);
         await assert.rejects(helpers.s3.uploadPart(
             {
                 UploadId: mpu.UploadId,

tests/functional/sse-kms-migration/helpers.js

@@ -94,6 +94,8 @@ async function createKmsKey(log) {
     });
 }
 
+const destroyKmsKey = promisify(kms.destroyBucketKey);
+
 async function cleanup(Bucket) {
     await bucketUtil.empty(Bucket);
     await s3.deleteBucket({ Bucket }).promise();
@@ -112,5 +114,6 @@ module.exports = {
     putEncryptedObject,
     getObjectMDSSE,
     createKmsKey,
+    destroyKmsKey,
     cleanup,
 };