Skip to content

Commit b6e1ad0

Browse files
committed
♻️ remove a useless error management and simplify the code
Issue: CLDSRV-823
1 parent 5e2122d commit b6e1ad0

1 file changed

Lines changed: 3 additions & 8 deletions

File tree

lib/api/bucketGet.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -388,24 +388,19 @@ async function bucketGet(authInfo, request, log, callback) {
388388
listParams.marker = params.marker;
389389
}
390390

391-
let error;
392391
let bucket;
393392

394393
try {
395394
const standardMetadataValidateBucketPromised = promisify(standardMetadataValidateBucket);
396395
bucket = await standardMetadataValidateBucketPromised(metadataValParams, request.actionImplicitDenies, log);
397396
} catch (err) {
398-
error = err;
397+
log.debug('error processing request', { err });
398+
monitoring.promMetrics('GET', bucketName, err.code, 'listBucket');
399+
throw err;
399400
}
400401

401402
const corsHeaders = collectCorsHeaders(request.headers.origin, request.method, bucket);
402403

403-
if (error) {
404-
log.debug('error processing request', { error });
405-
monitoring.promMetrics('GET', bucketName, error.code, 'listBucket');
406-
error.additionalResHeaders = corsHeaders;
407-
throw error;
408-
}
409404
if (params.versions !== undefined) {
410405
listParams.listingType = 'DelimiterVersions';
411406
delete listParams.marker;

0 commit comments

Comments
 (0)