CLDSRV-815: Remove redundant accountDisplayName field

Remove accountDisplayName field from server access logs as it was
redundant with accountName.
Both fields were populated from the same source
(authInfo.getAccountDisplayName()) and always contained
identical values.

Author: dvasilas

lib/utilities/serverAccessLogger.js

@@ -413,7 +413,6 @@ function logServerAccess(req, res) {
         // Analytics
         action: params.analyticsAction ?? undefined,
         accountName: params.analyticsAccountName ?? undefined,
-        accountDisplayName: authInfo?.getAccountDisplayName() ?? undefined,
         userName: params.analyticsUserName ?? undefined,
         httpMethod: req.method ?? undefined,
         bytesDeleted: params.analyticsBytesDeleted ?? undefined,

schema/server_access_log.schema.json

@@ -27,10 +27,6 @@
             "description": "Requester account display name.",
             "type": ["string", "null"]
         },
-        "accountDisplayName": {
-            "description": "Requester account display name.",
-            "type": ["string", "null"]
-        },
         "userName": {
             "description": "Requester IAM display name, or null if the requester is not an IAM user.",
             "type": ["string", "null"]

tests/functional/aws-node-sdk/test/serverAccessLogs/testServerAccessLogFile.js

@@ -118,7 +118,6 @@ describe('Server Access Logs - File Output', async () => {
             // 'pid': '', // UNKNOWN
             'action': 'REQUIRED', // DYNAMIC
             'accountName': 'Bart', // STATIC
-            'accountDisplayName': 'Bart', // STATIC
             'userName': null, // TODO: Add test with IAM user to get a non null userName.
             // 'clientPort': '', // UNKNOWN
             'httpMethod': 'REQUIRED', // DYNAMIC

tests/unit/utils/serverAccessLogger.js

@@ -803,7 +803,6 @@ describe('serverAccessLogger utility functions', () => {
             // Verify analytics fields
             assert.strictEqual(loggedData.action, 'ObjectGet');
             assert.strictEqual(loggedData.accountName, 'testAccount');
-            assert.strictEqual(loggedData.accountDisplayName, 'testAccount');
             assert.strictEqual(loggedData.userName, 'testUser');
             assert.strictEqual(loggedData.httpMethod, 'GET');
             assert.strictEqual(loggedData.bytesDeleted, 0);
@@ -890,7 +889,6 @@ describe('serverAccessLogger utility functions', () => {
 
             assert.strictEqual(mockLogger.write.callCount, 1);
             const loggedData = JSON.parse(mockLogger.write.firstCall.args[0].trim());
-            assert.strictEqual('accountDisplayName' in loggedData, false);
             assert.strictEqual('requester' in loggedData, false);
             assert.strictEqual('signatureVersion' in loggedData, false);
             assert.strictEqual('authenticationType' in loggedData, false);