♻️ move to manual callbackify

Issue: CLDSRV-823

Author: DarkIsDude

lib/api/bucketGet.js

@@ -1,4 +1,3 @@
-const { callbackify } = require('util');
 const querystring = require('querystring');
 const { errors, errorInstances, versioning, s3middleware } = require('arsenal');
 const constants = require('../../constants');
@@ -390,6 +389,13 @@ async function bucketGet(authInfo, request, log) {
 module.exports = {
     processVersions,
     processMasterVersions,
-    bucketGet: callbackify(bucketGet),
+    bucketGet: (...args) => {
+        const callback = args.at(-1);
+        const argsWithoutCallback = args.slice(0, -1);
+
+        bucketGet(...argsWithoutCallback)
+            .then(result => callback(null, ...result))
+            .catch(err => callback(err));
+    },
 };
 

lib/api/objectGetLegalHold.js

@@ -1,4 +1,3 @@
-const { callbackify } = require('util');
 const { errors, errorInstances, s3middleware } = require('arsenal');
 
 const { decodeVersionId, getVersionIdResHeader }
@@ -104,4 +103,11 @@ async function objectGetLegalHold(authInfo, request, log) {
     }
 }
 
-module.exports = callbackify(objectGetLegalHold);
+module.exports = (...args) => {
+    const callback = args.at(-1);
+    const argsWithoutCallback = args.slice(0, -1);
+
+    objectGetLegalHold(...argsWithoutCallback)
+        .then(result => callback(null, ...result))
+        .catch(err => callback(err));
+};