CLDSRV-909: Reject CopyObject when source exceeds 5 GiB

Author: tcarmet

lib/api/objectCopy.js

@@ -351,6 +351,16 @@ function objectCopy(authInfo, request, sourceBucket,
                         request.sourceServerAccessLog && (request.sourceServerAccessLog.error = err);
                         return next(err, destBucketMD);
                     }
+                    const sourceSize = parseInt(sourceObjMD['content-length'], 10);
+                    if (sourceSize > constants.maximumAllowedUploadSize) {
+                        log.debug('copy source object too large', { sourceSize });
+                        const err = errorInstances.InvalidRequest.customizeDescription(
+                            'The specified copy source is larger than the maximum ' +
+                            `allowable size for a copy source: ${constants.maximumAllowedUploadSize}`);
+                        // eslint-disable-next-line no-param-reassign
+                        request.sourceServerAccessLog && (request.sourceServerAccessLog.error = err);
+                        return next(err, destBucketMD);
+                    }
                     const headerValResult =
                         validateHeaders(request.headers,
                         sourceObjMD['last-modified'],

tests/unit/api/objectCopy.js

@@ -14,7 +14,8 @@ const { cleanup, DummyRequestLogger, makeAuthInfo, versioningTestUtils }
 const mpuUtils = require('../utils/mpuUtils');
 const metadata = require('../metadataswitch');
 const { data } = require('../../../lib/data/wrapper');
-const { objectLocationConstraintHeader } = require('../../../constants');
+const constants = require('../../../constants');
+const { objectLocationConstraintHeader } = constants;
 const { fakeMetadataArchive } = require('../../functional/aws-node-sdk/test/utils/init');
 const { config } = require('../../../lib/Config');
 
@@ -640,3 +641,47 @@ describe('objectCopy with objectKeyByteLimit', () => {
             });
     });
 });
+
+describe('objectCopy source size limit', () => {
+    const testPutObjectRequest = versioningTestUtils.createPutObjectRequest(sourceBucketName, objectKey, objData[0]);
+    const sourceSize = objData[0].length;
+    let originalMaximumUploadSize;
+
+    before(done => {
+        cleanup();
+        originalMaximumUploadSize = constants.maximumAllowedUploadSize;
+        async.series([
+            callback => bucketPut(authInfo, putDestBucketRequest, log, callback),
+            callback => bucketPut(authInfo, putSourceBucketRequest, log, callback),
+            callback => objectPut(authInfo, testPutObjectRequest, undefined, log, callback),
+        ], done);
+    });
+
+    after(() => {
+        constants.maximumAllowedUploadSize = originalMaximumUploadSize;
+        cleanup();
+    });
+
+    it('should allow CopyObject when source size equals the limit', done => {
+        constants.maximumAllowedUploadSize = sourceSize;
+        const testObjectCopyRequest = _createObjectCopyRequest(destBucketName);
+        objectCopy(authInfo, testObjectCopyRequest, sourceBucketName, objectKey,
+            undefined, log, err => {
+                assert.ifError(err);
+                done();
+            });
+    });
+
+    it('should reject CopyObject when source size exceeds the limit', done => {
+        constants.maximumAllowedUploadSize = sourceSize - 1;
+        const testObjectCopyRequest = _createObjectCopyRequest(destBucketName);
+        objectCopy(authInfo, testObjectCopyRequest, sourceBucketName, objectKey,
+            undefined, log, err => {
+                assert(err);
+                assert.strictEqual(err.is.InvalidRequest, true);
+                assert.match(err.description,
+                    /The specified copy source is larger than the maximum allowable size for a copy source/);
+                done();
+            });
+    });
+});