CLDSRV-909: Use plain if for sourceServerAccessLog error assignment

Author: tcarmet

lib/api/objectCopy.js

@@ -648,8 +648,10 @@ function objectCopy(authInfo, request, sourceBucket, sourceObject, sourceVersion
                                 'The specified copy source is larger than the maximum ' +
                                     `allowable size for a copy source: ${constants.maximumAllowedUploadSize}`,
                             );
-                            // eslint-disable-next-line no-param-reassign
-                            request.sourceServerAccessLog && (request.sourceServerAccessLog.error = err);
+                            if (request.sourceServerAccessLog) {
+                                // eslint-disable-next-line no-param-reassign
+                                request.sourceServerAccessLog.error = err;
+                            }
                             return next(err, destBucketMD);
                         }
                         const headerValResult = validateHeaders(

tests/unit/api/objectCopy.js

@@ -1918,10 +1918,9 @@ describe('objectCopy source size limit', () => {
         constants.maximumAllowedUploadSize = sourceSize - 1;
         config.bypassMaxPutObjectSize = true;
         const testObjectCopyRequest = _createObjectCopyRequest(destBucketName);
-        objectCopy(authInfo, testObjectCopyRequest, sourceBucketName, objectKey,
-            undefined, log, err => {
-                assert.ifError(err);
-                done();
-            });
+        objectCopy(authInfo, testObjectCopyRequest, sourceBucketName, objectKey, undefined, log, err => {
+            assert.ifError(err);
+            done();
+        });
     });
 });