do not allow crr location as an object locationConstraint

Issue: CLDSRV-653

Author: Kerkesni

lib/api/objectCopy.js

@@ -130,7 +130,7 @@ function _prepMetadata(request, sourceObjMD, headers, sourceIsDestination,
     const backendInfoObjDest = locationConstraintCheck(request,
         userMetadata, destBucketMD, log);
     if (backendInfoObjDest.err) {
-        return { error: backendInfoObjSource.err };
+        return { error: backendInfoObjDest.err };
     }
     const destLocationConstraintName = backendInfoObjDest.controllingLC;
 

package.json

@@ -21,7 +21,7 @@
   "dependencies": {
     "@azure/storage-blob": "^12.25.0",
     "@hapi/joi": "^17.1.1",
-    "arsenal": "git+https://github.com/scality/Arsenal#8.2.21",
+    "arsenal": "git+https://github.com/scality/Arsenal#8.2.22",
     "async": "2.6.4",
     "aws-sdk": "^2.1692.0",
     "bucketclient": "scality/bucketclient#8.2.4",

tests/unit/api/multipartUpload.js

@@ -2174,6 +2174,32 @@ describe('Multipart Upload API', () => {
             },
         ], done);
     });
+
+    it('should fail to initiate a multipart upload if location constraint is crr', done => {
+        const initiateRequest = {
+            socket: {
+                remoteAddress: '1.1.1.1',
+            },
+            bucketName,
+            namespace,
+            objectKey,
+            headers: {
+                host: `${bucketName}.s3.amazonaws.com`,
+                [constants.objectLocationConstraintHeader]: 'location-crr-v1',
+            },
+            url: `/${objectKey}?uploads`,
+            actionImplicitDenies: false,
+        };
+
+        bucketPut(authInfo, bucketPutRequest, log, err => {
+            assert.ifError(err);
+            initiateMultipartUpload(authInfo, initiateRequest,
+                log, err => {
+                    assert(err.is.InvalidArgument);
+                    done();
+                });
+        });
+    });
 });
 
 describe('complete mpu with versioning', () => {

tests/unit/api/objectCopy.js

@@ -39,12 +39,12 @@ function _createBucketPutRequest(bucketName) {
     });
 }
 
-function _createObjectCopyRequest(destBucketName) {
+function _createObjectCopyRequest(destBucketName, headers = {}) {
     const params = {
         bucketName: destBucketName,
         namespace,
         objectKey,
-        headers: {},
+        headers,
         url: `/${destBucketName}/${objectKey}`,
         socket: {},
     };
@@ -231,6 +231,7 @@ describe('non-versioned objectCopy', () => {
         cleanup();
         sinon.stub(metadata, 'putObjectMD')
             .callsFake(originalputObjectMD);
+
         async.series([
             callback => bucketPut(authInfo, putDestBucketRequest, log,
                 callback),
@@ -338,6 +339,22 @@ describe('non-versioned objectCopy', () => {
             },
         ], done);
     });
+
+    it('should fail to copy object when setting a crr location as the locationConstraint', done => {
+        const testObjectCopyRequest = _createObjectCopyRequest(destBucketName, {
+            'x-amz-metadata-directive': 'REPLACE', // needed to take the locationConstraint into account
+            [objectLocationConstraintHeader]: 'location-crr-v1',
+        });
+
+        async.series([
+            next => objectPut(authInfo, testPutDestObjectRequest, undefined, log, next),
+            next => objectCopy(authInfo, testObjectCopyRequest, sourceBucketName, objectKey,
+                undefined, log, next),
+        ], err => {
+            assert(err.is.InvalidArgument);
+            done();
+        });
+    });
 });
 
 describe('objectCopy overheadField', () => {

tests/unit/api/objectPut.js

@@ -843,6 +843,27 @@ describe('objectPut API', () => {
             });
         });
     });
+
+    it('should fail to put object when setting a crr location as the locationConstraint', done => {
+        const testPutObjectRequest = new DummyRequest({
+            bucketName,
+            namespace,
+            objectKey: objectName,
+            headers: {
+                [objectLocationConstraintHeader]: 'location-crr-v1',
+            },
+            url: `/${bucketName}/${objectName}`,
+            calculatedHash: 'vnR+tLdVF79rPPfF+7YvOg==',
+        }, postBody);
+
+        bucketPut(authInfo, testPutBucketRequest, log, () => {
+            objectPut(authInfo, testPutObjectRequest, undefined, log,
+                err => {
+                    assert(err.is.InvalidArgument);
+                    done();
+                });
+        });
+    });
 });
 
 describe('objectPut API with versioning', () => {

yarn.lock

@@ -1296,9 +1296,9 @@ arraybuffer.prototype.slice@^1.0.4:
     get-intrinsic "^1.2.6"
     is-array-buffer "^3.0.4"
 
-"arsenal@git+https://github.com/scality/Arsenal#8.2.21":
-  version "8.2.21"
-  resolved "git+https://github.com/scality/Arsenal#534e10f48d170b0c4dff9bd818376f796eac8aaa"
+"arsenal@git+https://github.com/scality/Arsenal#8.2.22":
+  version "8.2.22"
+  resolved "git+https://github.com/scality/Arsenal#034de2bdfa7526111fe21c60205f1e94e5078f46"
   dependencies:
     "@azure/identity" "^4.10.0"
     "@azure/storage-blob" "^12.27.0"