Improve logging levels post review

Issue: CLDSRV-613

Author: Seragonia

lib/api/apiUtils/object/coldStorage.js

@@ -253,7 +253,6 @@ function startRestore(objectMD, restoreParam, log, cb) {
         });
         return cb(checkResultError);
     }
-    log.debug('Updating restore information.');
     const updateResultError = _updateRestoreInfo(objectMD, restoreParam, log);
     if (updateResultError) {
         log.debug('Failed to update restore information.', {
@@ -262,6 +261,9 @@ function startRestore(objectMD, restoreParam, log, cb) {
         });
         return cb(updateResultError);
     }
+    log.debug('Validated and updated restore information', {
+         method: 'startRestore'
+    });
     const isObjectAlreadyRestored = _updateObjectExpirationDate(objectMD, log);
     return cb(null, isObjectAlreadyRestored);
 }

lib/api/apiUtils/object/objectRestore.js

@@ -94,7 +94,7 @@ function objectRestore(metadata, mdUtils, userInfo, request, log, callback) {
                         log.trace('version is a delete marker', { method: METHOD, error: err });
                         return next(err, bucketMD, objectMD);
                     }
-                    log.debug('it acquired the object metadata.', {
+                    log.debug('acquired the object metadata.', {
                         'method': METHOD,
                     });
                     return next(null, bucketMD, objectMD);
@@ -108,7 +108,7 @@ function objectRestore(metadata, mdUtils, userInfo, request, log, callback) {
                     if (err) {
                         return next(err, bucketMD, objectMD, restoreInfo);
                     }
-                    log.debug('it parsed xml of the request body.', { method: METHOD, value: restoreInfo });
+                    log.debug('parsed xml of the request body.', { method: METHOD, value: restoreInfo });
                     const checkTierResult = checkTierSupported(restoreInfo);
                     if (checkTierResult instanceof Error) {
                         return next(checkTierResult);

lib/api/completeMultipartUpload.js

@@ -457,7 +457,7 @@ function completeMultipartUpload(authInfo, request, log, callback) {
                 //   the previous MPU completion attempt
                 //
                 if (!locationKeysHaveChanged(objMD.location, dataLocations)) {
-                    log.debug('MPU complete request replay detected', {
+                    log.info('MPU complete request replay detected', {
                         method: 'completeMultipartUpload.storeAsNewObj',
                         bucketName: destinationBucket.getName(),
                         objectKey: metaStoreParams.objectKey,

lib/routes/routeBackbeat.js

@@ -605,7 +605,7 @@ function putMetadata(request, response, bucketInfo, objMd, log, callback) {
                     // transition processor.
                     omVal.location && Array.isArray(omVal.location) &&
                     locationKeysHaveChanged(objMd.location, omVal.location)) {
-                    log.debug('removing old data locations', {
+                    log.info('removing old data locations', {
                         method: 'putMetadata',
                         bucketName,
                         objectKey,
@@ -1160,7 +1160,7 @@ function batchDelete(request, response, userInfo, log, callback) {
             }
             dataWrapper.data.delete(_loc, log, err => {
                 if (err?.is?.ObjNotFound) {
-                    log.warn('batch delete: data location do not exist', {
+                    log.info('batch delete: data location do not exist', {
                         method: 'batchDelete',
                         location: loc,
                     });