bf: CLDSRV-647 crash in getReplicationInfo with no replication endpoint

Fix an exception in getReplicationInfo when:

- no StorageClass is provided
- no replication endpoint is configured

Instead, return `undefined` so the object is not set to PENDING state
for replication, even if the bucket already has a replication
configuration enabled.

Author: jonathan-gramain

lib/api/apiUtils/object/getReplicationInfo.js

@@ -25,6 +25,9 @@ function _getStorageClasses(s3config, rule) {
             replicationEndpoints.find(endpoint => endpoint.default);
         return [endPoint.site];
     }
+    if (replicationEndpoints.length === 0) {
+        return [];
+    }
     return [replicationEndpoints[0].site];
 }
 
@@ -33,6 +36,9 @@ function _getReplicationInfo(s3config, rule, replicationConfig, content, operati
     const storageTypes = [];
     const backends = [];
     const storageClasses = _getStorageClasses(s3config, rule);
+    if (storageClasses.length === 0) {
+        return undefined;
+    }
     storageClasses.forEach(storageClass => {
         const location = s3config.locationConstraints[storageClass];
         if (location && ['aws_s3', 'azure'].includes(location.type)) {

tests/unit/api/apiUtils/getReplicationInfo.js

@@ -157,4 +157,78 @@ describe('getReplicationInfo helper', () => {
 
         assert.deepStrictEqual(replicationInfo, undefined);
     });
+
+    it('should get replication info with default StorageClass when rules are enabled', () => {
+        const replicationConfig = {
+            role: 'arn:aws:iam::root:role/s3-replication-role-1,arn:aws:iam::root:role/s3-replication-role-2',
+            rules: [{
+                prefix: '',
+                enabled: true,
+            }],
+            destination: 'tosomewhere',
+        };
+        const replicationInfo = _getObjectReplicationInfo(TEST_CONFIG, replicationConfig);
+        assert.deepStrictEqual(replicationInfo, {
+            status: 'PENDING',
+            backends: [{
+                site: 'zenko',
+                status: 'PENDING',
+                dataStoreVersionId: '',
+            }],
+            content: ['METADATA'],
+            destination: 'tosomewhere',
+            storageClass: 'zenko',
+            role: 'arn:aws:iam::root:role/s3-replication-role-1,arn:aws:iam::root:role/s3-replication-role-2',
+            storageType: '',
+        });
+    });
+
+    it('should return undefined with specified StorageClass mode if no replication endpoint is configured', () => {
+        const replicationConfig = {
+            role: 'arn:aws:iam::root:role/s3-replication-role',
+            rules: [{
+                prefix: '',
+                enabled: true,
+                storageClass: 'awsbackend',
+            }],
+            destination: 'tosomewhere',
+        };
+        const configWithNoReplicationEndpoint = {
+            locationConstraints: TEST_CONFIG.locationConstraints,
+            replicationEndpoints: [],
+        };
+        const replicationInfo = _getObjectReplicationInfo(configWithNoReplicationEndpoint,
+            replicationConfig);
+        assert.deepStrictEqual(replicationInfo, {
+            status: 'PENDING',
+            backends: [{
+                site: 'awsbackend',
+                status: 'PENDING',
+                dataStoreVersionId: '',
+            }],
+            content: ['METADATA'],
+            destination: 'tosomewhere',
+            storageClass: 'awsbackend',
+            role: 'arn:aws:iam::root:role/s3-replication-role',
+            storageType: 'aws_s3',
+        });
+    });
+
+    it('should return undefined with default StorageClass if no replication endpoint is configured', () => {
+        const replicationConfig = {
+            role: 'arn:aws:iam::root:role/s3-replication-role-1,arn:aws:iam::root:role/s3-replication-role-2',
+            rules: [{
+                prefix: '',
+                enabled: true,
+            }],
+            destination: 'tosomewhere',
+        };
+        const configWithNoReplicationEndpoint = {
+            locationConstraints: TEST_CONFIG.locationConstraints,
+            replicationEndpoints: [],
+        };
+        const replicationInfo = _getObjectReplicationInfo(configWithNoReplicationEndpoint,
+            replicationConfig);
+        assert.deepStrictEqual(replicationInfo, undefined);
+    });
 });