Skip to content

Commit de486c3

Browse files
committed
fixup! async/await on objects tests
fix awaiting on before/after
1 parent d4d21a7 commit de486c3

1 file changed

Lines changed: 22 additions & 11 deletions

File tree

  • tests/functional/raw-node/test/GCP/object

tests/functional/raw-node/test/GCP/object/head.js

Lines changed: 22 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,18 @@ describe('GCP: HEAD Object', function testSuite() {
4747
if (!this.currentTest.key) {
4848
return;
4949
}
50-
await gcpClient.deleteObject({
51-
Bucket: bucketName,
52-
Key: this.currentTest.key,
50+
await new Promise((resolve, reject) => {
51+
gcpClient.deleteObject({
52+
Bucket: bucketName,
53+
Key: this.currentTest.key,
54+
}, err => {
55+
if (err) {
56+
process.stdout.write(`err in deleting object ${err}\n`);
57+
reject(err);
58+
return;
59+
}
60+
resolve();
61+
});
5362
});
5463
});
5564

@@ -65,15 +74,17 @@ describe('GCP: HEAD Object', function testSuite() {
6574
});
6675

6776
describe('without existing object in bucket', () => {
68-
it('should return 404', done => {
77+
it('should return 404', async () => {
6978
const badObjectkey = `nonexistingkey-${genUniqID()}`;
70-
gcpClient.headObject({
71-
Bucket: bucketName,
72-
Key: badObjectkey,
73-
}, err => {
74-
assert(err);
75-
assert.strictEqual(err.$metadata.httpStatusCode, 404);
76-
return done();
79+
await new Promise(resolve => {
80+
gcpClient.headObject({
81+
Bucket: bucketName,
82+
Key: badObjectkey,
83+
}, err => {
84+
assert(err);
85+
assert.strictEqual(err.$metadata.httpStatusCode, 404);
86+
resolve();
87+
});
7788
});
7889
});
7990
});

0 commit comments

Comments
 (0)